Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: chrome/browser/extensions/page_action_controller.h

Issue 10446005: Revert half of the changes from 137638 that are probably causing breakages in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_controller.h
diff --git a/chrome/browser/extensions/page_action_controller.h b/chrome/browser/extensions/page_action_controller.h
index cdb43a3d49ca9aa088d594a576b4659671d6a930..bfa3d0fcbf06b15675880990b3daa470cbe072e4 100644
--- a/chrome/browser/extensions/page_action_controller.h
+++ b/chrome/browser/extensions/page_action_controller.h
@@ -11,7 +11,6 @@
#include "base/observer_list.h"
#include "chrome/browser/extensions/action_box_controller.h"
-#include "chrome/browser/extensions/extension_tab_helper.h"
class ExtensionService;
class TabContentsWrapper;
@@ -19,11 +18,9 @@ class TabContentsWrapper;
namespace extensions {
// An ActionBoxController which corresponds to the page actions of an extension.
-class PageActionController : public ActionBoxController,
- public ExtensionTabHelper::Observer {
+class PageActionController : public ActionBoxController {
public:
- PageActionController(TabContentsWrapper* tab_contents,
- ExtensionTabHelper* tab_helper);
+ explicit PageActionController(TabContentsWrapper* tab_contents);
virtual ~PageActionController();
// ActionBoxController implementation.
@@ -32,17 +29,12 @@ class PageActionController : public ActionBoxController,
virtual Action OnClicked(const std::string& extension_id,
int mouse_button) OVERRIDE;
- // ExtensionTabHelper::Observer implementation.
- virtual void OnPageActionStateChanged() OVERRIDE;
-
private:
// Gets the ExtensionService for |tab_contents_|.
ExtensionService* GetExtensionService();
TabContentsWrapper* tab_contents_;
- ExtensionTabHelper* tab_helper_;
-
DISALLOW_COPY_AND_ASSIGN(PageActionController);
};
« no previous file with comments | « chrome/browser/extensions/extension_tab_helper.cc ('k') | chrome/browser/extensions/page_action_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698