Valgrind: Fix a leak in OneClickSigninHelperTest.

chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

Index: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
index 7622cf2ff0ad5ba29ab990d3ec1bcc566a834f1f..a89b6fce84264c688781c791159d4e075b211bdc 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
@@ -67,6 +67,7 @@ void OneClickSigninHelperTest::TearDown() {
   web_contents_.reset();
   profile_.reset();
   ui_thread_.reset();
+  MessageLoop::current()->RunAllPending();

[Roger Tawa OOO till Jul 10th, 2012/06/01 13:56:42]

Are you sure this should/can be done after destroying the browser context (i.e.
test profile) and ui thread?

[James Hawkins, 2012/06/01 23:53:13]

In what context are you asking this question?  What are your concerns?

[Roger Tawa OOO till Jul 10th, 2012/06/04 14:50:40]

My concern is calling RunAllPending() after the destruction of the
content::TestBrowserThread object. Also, there may be tasks to run for the
browsing context.  Other tests make sure not to do this, see TearDown() in
src/content/test/test_renderer_host.cc for example.

 }
 
 void OneClickSigninHelperTest::MarkCurrentThreadAsUIThread() {