Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2455)

Unified Diff: chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc

Issue 10444125: Valgrind: Fix a leak in OneClickSigninHelperTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
diff --git a/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc b/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
index 11525476ac2a4709f34e4e14cbde5111a35bd3af..089ce17f9fdd42e80b43f28cc94d3c3c89b34d38 100644
--- a/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
+++ b/chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
@@ -69,10 +69,6 @@ class MockWebAuthFlow : public WebAuthFlow {
return window_;
}
- WebContents* contents() {
- return web_contents_;
Roger Tawa OOO till Jul 10th 2012/06/01 13:56:42 Why is this change needed to fix the memory leak?
James Hawkins 2012/06/01 23:53:13 Didn't say it was. It's drive-by cleanup I saw wh
Roger Tawa OOO till Jul 10th 2012/06/04 14:50:40 OK, the CL description did not mention it included
- }
-
WebContentsTester* contents_tester() {
return WebContentsTester::For(web_contents_);
}

Powered by Google App Engine
This is Rietveld 408576698