Valgrind: Fix a leak in OneClickSigninHelperTest.

chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_manager_fake.h"
@@ skipping 49 matching lines @@
   SigninManager* signin_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelperTest);
 };
 
 void OneClickSigninHelperTest::TearDown() {
   // Destroy things in proper order.
   web_contents_.reset();
   profile_.reset();
   ui_thread_.reset();
+  MessageLoop::current()->RunAllPending();

[Roger Tawa OOO till Jul 10th, 2012/06/01 13:56:42]

Are you sure this should/can be done after destroying the browser context (i.e.
test profile) and ui thread?

[James Hawkins, 2012/06/01 23:53:13]

In what context are you asking this question?  What are your concerns?

[Roger Tawa OOO till Jul 10th, 2012/06/04 14:50:40]

My concern is calling RunAllPending() after the destruction of the
content::TestBrowserThread object. Also, there may be tasks to run for the
browsing context.  Other tests make sure not to do this, see TearDown() in
src/content/test/test_renderer_host.cc for example.

 }
 
 void OneClickSigninHelperTest::MarkCurrentThreadAsUIThread() {
   ui_thread_.reset(new content::TestBrowserThread(
       content::BrowserThread::UI, &message_loop_));
 }
 
 content::WebContents* OneClickSigninHelperTest::CreateMockWebContents(
     bool use_incognito) {
   EXPECT_TRUE(web_contents_.get() == NULL);
@@ skipping 65 matching lines @@
 }
 
 TEST_F(OneClickSigninHelperTest, CanOfferNoSigninCookies) {
   MarkCurrentThreadAsUIThread();
   content::WebContents* web_contents = CreateMockWebContents(true);
   AllowSigninCookies(false);
 
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(web_contents, true));
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(web_contents, false));
 }