Valgrind: Fix a leak in OneClickSigninHelperTest.

chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "chrome/browser/extensions/api/identity/web_auth_flow.h"
 #include "chrome/browser/ui/extensions/web_auth_flow_window.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 51 matching lines @@
         browser_context_, NULL);
     return web_contents_;
   }
 
   virtual WebAuthFlowWindow* CreateAuthWindow() OVERRIDE {
     CHECK(!window_);
     window_ = new MockWebAuthFlowWindow();
     return window_;
   }
 
-  WebContents* contents() {
-    return web_contents_;

[Roger Tawa OOO till Jul 10th, 2012/06/01 13:56:42]

Why is this change needed to fix the memory leak?

[James Hawkins, 2012/06/01 23:53:13]

Didn't say it was.  It's drive-by cleanup I saw while fixing this issue.

[Roger Tawa OOO till Jul 10th, 2012/06/04 14:50:40]

OK, the CL description did not mention it included other drive by cleanup, so it
was not clear it was that.  Maybe update the CL description?

-  }
-
   WebContentsTester* contents_tester() {
     return WebContentsTester::For(web_contents_);
   }
 
   MockWebAuthFlowWindow& window() {
     return *window_;
   }
 
   bool HasWindow() const {
     return window_ != NULL;
@@ skipping 122 matching lines @@
   // http scheme is not allowed.
   EXPECT_FALSE(CallIsValidRedirectUrl(
       GURL("http://abcdefghij.chromiumapp.org/callback")));
   EXPECT_FALSE(CallIsValidRedirectUrl(
       GURL("https://abcd.chromiumapp.org/callback")));
   EXPECT_FALSE(CallIsValidRedirectUrl(
       GURL("chrome-extension://abcd/callback")));
   EXPECT_FALSE(CallIsValidRedirectUrl(
       GURL("chrome-extension://abcdefghijkl/")));
 }