Issue 10444065: Switch all domstorage tasks to be shutdown blocking to allow changes to be flushed to disk on shutd…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10444065: Switch all domstorage tasks to be shutdown blocking to allow changes to be flushed to disk on shutd… (Closed)

Created:
8 years, 6 months ago by michaeln

Modified:
8 years, 6 months ago

Reviewers:
ericu

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Switch all domstorage tasks to be shutdown blocking to allow changes to be flushed to disk on shutdown. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139383

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	webkit/dom_storage/dom_storage_task_runner.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
	M	webkit/dom_storage/dom_storage_task_runner.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ericu

LGTM https://chromiumcodereview.appspot.com/10444065/diff/1/webkit/dom_storage/dom_storage_task_runner.cc File webkit/dom_storage/dom_storage_task_runner.cc (right): https://chromiumcodereview.appspot.com/10444065/diff/1/webkit/dom_storage/dom_storage_task_runner.cc#newcode54 webkit/dom_storage/dom_storage_task_runner.cc:54: base::SequencedWorkerPool::BLOCK_SHUTDOWN); As discussed, perhaps a TODO to have ...

8 years, 6 months ago (2012-05-29 20:35:11 UTC) #2

michaeln

8 years, 6 months ago (2012-05-29 21:46:52 UTC) #3

> As discussed, perhaps a TODO to have read tasks be SKIP and write tasks be
> BLOCK?

Done, added a TODO in the .h file

Expand Messages | Collapse Messages

Issue 10444065: Switch all domstorage tasks to be shutdown blocking to allow changes to be flushed to disk on shutd… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages