Switch all domstorage tasks to be shutdown blocking to allow changes to be flushed to disk on shutd…

webkit/dom_storage/dom_storage_task_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/dom_storage/dom_storage_task_runner.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/message_loop_proxy.h"
 #include "base/tracked_objects.h"
@@ skipping 33 matching lines @@
 bool DomStorageWorkerPoolTaskRunner::PostDelayedTask(
     const tracked_objects::Location& from_here,
     const base::Closure& task,
     base::TimeDelta delay) {
   // Note base::TaskRunner implements PostTask in terms of PostDelayedTask
   // with a delay of zero, we detect that usage and avoid the unecessary
   // trip thru the message loop.
   if (delay == base::TimeDelta()) {
     return sequenced_worker_pool_->PostSequencedWorkerTaskWithShutdownBehavior(
         primary_sequence_token_, from_here, task,
-        base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
+        base::SequencedWorkerPool::BLOCK_SHUTDOWN);

[ericu, 2012/05/29 20:35:11]

As discussed, perhaps a TODO to have read tasks be SKIP and write tasks be
BLOCK?

   }
   // Post a task to call this->PostTask() after the delay.
   return message_loop_->PostDelayedTask(
       FROM_HERE,
       base::Bind(base::IgnoreResult(&DomStorageWorkerPoolTaskRunner::PostTask),
                  this, from_here, task),
       delay);
 }
 
 bool DomStorageWorkerPoolTaskRunner::PostShutdownBlockingTask(
@@ skipping 41 matching lines @@
     SequenceID sequence_id,
     const base::Closure& task) {
   return message_loop_->PostTask(from_here, task);
 }
 
 bool MockDomStorageTaskRunner::IsRunningOnSequence(SequenceID) const {
   return message_loop_->RunsTasksOnCurrentThread();
 }
 
 }  // namespace dom_storage