Switch all domstorage tasks to be shutdown blocking to allow changes to be flushed to disk on shutd…

webkit/dom_storage/dom_storage_task_runner.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_
 #define WEBKIT_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "base/sequenced_task_runner.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/time.h"
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace dom_storage {
 
 // DomStorage uses two task sequences (primary vs commit) to avoid
 // primary access from queuing up behind commits to disk.
 // * Initialization, shutdown, and administrative tasks are performed as
 //   shutdown-blocking primary sequence tasks.
-// * Methods that return values to the javascript'able interface are performed
-//   as non-shutdown-blocking primary sequence tasks.
+// * Tasks directly related to the javascript'able interface are performed
+//   as shutdown-blocking primary sequence tasks.
+//   TODO(michaeln): Skip tasks for reading during shutdown.
 // * Internal tasks related to committing changes to disk are performed as
 //   shutdown-blocking commit sequence tasks.
 class DomStorageTaskRunner : public base::TaskRunner {
  public:
   enum SequenceID {
     PRIMARY_SEQUENCE,
     COMMIT_SEQUENCE
   };
 
   // The PostTask() and PostDelayedTask() methods defined by TaskRunner
-  // post non-shutdown-blocking tasks on the primary sequence.
+  // post shutdown-blocking tasks on the primary sequence.
   virtual bool PostDelayedTask(
       const tracked_objects::Location& from_here,
       const base::Closure& task,
       base::TimeDelta delay) = 0;
 
   // Posts a shutdown blocking task to |sequence_id|.
   virtual bool PostShutdownBlockingTask(
       const tracked_objects::Location& from_here,
       SequenceID sequence_id,
       const base::Closure& task) = 0;
@@ skipping 82 matching lines @@
  protected:
   virtual ~MockDomStorageTaskRunner();
 
  private:
   const scoped_refptr<base::MessageLoopProxy> message_loop_;
 };
 
 }  // namespace dom_storage
 
 #endif  // WEBKIT_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_