Chromium Code Reviews Chromium Code Reviews
Issue
10444014:
ash: Improved window maximize/restore animations (Closed)
DescriptionReland: ash: Improved window maximize/restore animations
This implements a cross-fade while scaling the window between the new and old size.
When a maximize animation is triggered we grab the window's current layer (and those of child windows) and start an animation on those layers to scale them up to full size. Simultaneously, we install a fresh layer for the window, set the bounds to fill the workspace, and tell the window to paint. We scale down that layer to match the window size at the start of the animation, then fade it in while scaling it up to full size.
The restore animation essentially does the above in reverse. However, we always keep the higher resolution layer on top (it looks better), and we always keep the lower layer fully opaque (so the desktop doesn't bleed through).
The animation is aborted if the window is closed mid-animation or the GPU process crashes mid-animation.
The animation does not yet work for app windows, see crbug.com/131293
BUG=116618
TEST=aura_shell_unittests WorkspaceManagerTest and WindowAnimationsTest, trigger slow window animation with shift-click on maximize widget and close window during animation, kill -9 the GPU process during the animation and observe that Chrome recovers
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139494
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140698
Patch Set 1 #Patch Set 2 : cleanup #Patch Set 3 : getting close #Patch Set 4 : tests in progress #Patch Set 5 : fix workspace mgr, remove ignore_window, cleanup #
Total comments: 3
Patch Set 6 : rename WindowAnimationWorkspaceTest, fix aura_bench #Patch Set 7 : move animation slowdown to separate CL #Patch Set 8 : fix lock screen, app windows #
Messages
Total messages: 8 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
