Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10441087: Plum through ANGLE_depth_texture (Closed)

Created:
8 years, 6 months ago by greggman
Modified:
8 years, 6 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Plum through ANGLE_depth_texture TEST=unit tests BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141117

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+951 lines, -27 lines) Patch
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt View 1 2 3 4 5 6 1 chunk +38 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 chunks +14 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 3 4 5 6 5 chunks +79 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 2 3 4 5 13 chunks +246 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 1 chunk +10 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 7 8 chunks +102 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 4 5 2 chunks +156 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 4 2 chunks +28 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A gpu/command_buffer/tests/gl_depth_texture_unittest.cc View 1 2 3 4 1 chunk +205 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, PTAL. Sorry it's go big :-(
8 years, 6 months ago (2012-06-07 21:42:28 UTC) #1
apatrick_chromium
Looks right but you have some trybot issues. http://codereview.chromium.org/10441087/diff/16001/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt (right): http://codereview.chromium.org/10441087/diff/16001/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt#newcode57 gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt:57: "Texture ...
8 years, 6 months ago (2012-06-07 22:11:36 UTC) #2
greggman
http://codereview.chromium.org/10441087/diff/16001/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt (right): http://codereview.chromium.org/10441087/diff/16001/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt#newcode57 gpu/GLES2/extensions/CHROMIUM/CHROMIUM_depth_texture.txt:57: "Texture Access" add a new paragraph before the last ...
8 years, 6 months ago (2012-06-07 22:53:31 UTC) #3
apatrick_chromium
8 years, 6 months ago (2012-06-07 22:54:48 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698