Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 10422005: Merge 116562 - IndexedDB: call abort handler when there are problems committing (Closed)

Created:
8 years, 7 months ago by jsbell
Modified:
8 years, 7 months ago
Reviewers:
alecflett
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 116562 - IndexedDB: call abort handler when there are problems committing https://bugs.webkit.org/show_bug.cgi?id=85841 Patch by Alec Flett <alecflett@chromium.org>; on 2012-05-09 Reviewed by Ojan Vafai. No new tests. Every existing test that calls commit() is testing the success side of this, and this only throws when there are LevelDB errors, which is exactly what we're trying to diagnose with this patch. * Modules/indexeddb/IDBBackingStore.h: (Transaction): * Modules/indexeddb/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::deleteDatabase): (WebCore::IDBLevelDBBackingStore::Transaction::commit): * Modules/indexeddb/IDBLevelDBBackingStore.h: (Transaction): * Modules/indexeddb/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::commit): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M Source/WebCore/Modules/indexeddb/IDBBackingStore.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jsbell
8 years, 7 months ago (2012-05-22 20:35:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698