Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp - Issue 10422005: Merge 116562 - IndexedDB: call abort handler when there are problems committing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp

Issue 10422005: Merge 116562 - IndexedDB: call abort handler when there are problems committing (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h ('k') | Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp

===================================================================

--- Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp (revision 118040)

+++ Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp (working copy)

@@ -309,8 +309,7 @@

const Vector<char> key = DatabaseNameKey::encode(m_identifier, name);

m_currentTransaction->remove(key);

- transaction->commit();

- return true;

+ return transaction->commit();

}

static bool checkObjectStoreAndMetaDataType(const LevelDBIterator* it, const Vector<char>& stopKey, int64_t objectStoreId, int64_t metaDataType)

@@ -1575,11 +1574,12 @@

m_backingStore->m_currentTransaction = LevelDBTransaction::create(m_backingStore->m_db.get());

}

-void IDBLevelDBBackingStore::Transaction::commit()

+bool IDBLevelDBBackingStore::Transaction::commit()

{

ASSERT(m_backingStore->m_currentTransaction);

- m_backingStore->m_currentTransaction->commit();

+ bool result = m_backingStore->m_currentTransaction->commit();

m_backingStore->m_currentTransaction.clear();

+ return result;

}

void IDBLevelDBBackingStore::Transaction::rollback()