Issue 10413061: Make PageInfoBubble not use BrowserList::GetLastActive and instead obtain a navigator at creation t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10413061: Make PageInfoBubble not use BrowserList::GetLastActive and instead obtain a navigator at creation t… (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make PageInfoBubble not use BrowserList::GetLastActive and instead obtain a navigator at creation time. http://crbug.com/129187 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138724

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -37 lines)			Patch
M	chrome/browser/chromeos/login/simple_web_view_dialog.h	View	1 2 3 4	3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/simple_web_view_dialog.cc	View	1 2 3 4	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/page_info_bubble_controller.h	View	1 2 3 4	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/page_info_bubble_controller.mm	View	1 2 3 4	5 chunks	+13 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/cocoa/page_info_bubble_controller_unittest.mm	View	1 2 3 4	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/page_info_bubble_gtk.cc	View	1 2 3 4	6 chunks	+17 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/page_info_bubble.h	View	1 2 3 4	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/browser_dialogs.h	View	1 2 3 4	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/page_info_bubble_view.h	View	1 2 3 4	3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/page_info_bubble_view.cc	View	1 2 3 4	3 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

8 years, 7 months ago (2012-05-23 16:33:24 UTC) #2

LGTM, one nit.

And thanks!

https://chromiumcodereview.appspot.com/10413061/diff/7004/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/page_info_bubble_controller.mm (right):

https://chromiumcodereview.appspot.com/10413061/diff/7004/chrome/browser/ui/c...
chrome/browser/ui/cocoa/page_info_bubble_controller.mm:186:
navigator:(content::PageNavigator*)navigator{
nit: space before {

Expand Messages | Collapse Messages