Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chrome/browser/ui/views/browser_dialogs.h

Issue 10413061: Make PageInfoBubble not use BrowserList::GetLastActive and instead obtain a navigator at creation t… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/page_info_bubble.h ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_
6 #define CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "ui/gfx/native_widget_types.h" 11 #include "ui/gfx/native_widget_types.h"
12 12
13 // This file contains functions for running a variety of browser dialogs and 13 // This file contains functions for running a variety of browser dialogs and
14 // popups. The dialogs here are the ones that the caller does not need to 14 // popups. The dialogs here are the ones that the caller does not need to
15 // access the class of the popup. It allows us to break dependencies by 15 // access the class of the popup. It allows us to break dependencies by
16 // allowing the callers to not depend on the classes implementing the dialogs. 16 // allowing the callers to not depend on the classes implementing the dialogs.
17 // TODO: Make as many of these methods as possible cross platform, and move them 17 // TODO: Make as many of these methods as possible cross platform, and move them
18 // into chrome/browser/ui/browser_dialogs.h. 18 // into chrome/browser/ui/browser_dialogs.h.
19 19
20 class BrowserView; 20 class BrowserView;
21 class EditSearchEngineControllerDelegate; 21 class EditSearchEngineControllerDelegate;
22 class FindBar; 22 class FindBar;
23 class GURL; 23 class GURL;
24 class Profile; 24 class Profile;
25 class TabContentsWrapper; 25 class TabContentsWrapper;
26 class TemplateURL; 26 class TemplateURL;
27 27
28 namespace content { 28 namespace content {
29 class PageNavigator;
29 struct SSLStatus; 30 struct SSLStatus;
30 } 31 }
31 32
32 namespace extensions { 33 namespace extensions {
33 class Extension; 34 class Extension;
34 } 35 }
35 36
36 namespace gfx { 37 namespace gfx {
37 class Size; 38 class Size;
38 } 39 }
(...skipping 16 matching lines...) Expand all
55 // Shows or hides the Chrome To Mobile bubble anchored to the supplied view. 56 // Shows or hides the Chrome To Mobile bubble anchored to the supplied view.
56 void ShowChromeToMobileBubbleView(views::View* anchor_view, Profile* profile); 57 void ShowChromeToMobileBubbleView(views::View* anchor_view, Profile* profile);
57 void HideChromeToMobileBubbleView(); 58 void HideChromeToMobileBubbleView();
58 bool IsChromeToMobileBubbleViewShowing(); 59 bool IsChromeToMobileBubbleViewShowing();
59 60
60 // Shows the page info bubble anchored to the supplied view. 61 // Shows the page info bubble anchored to the supplied view.
61 void ShowPageInfoBubble(views::View* anchor_view, 62 void ShowPageInfoBubble(views::View* anchor_view,
62 Profile* profile, 63 Profile* profile,
63 const GURL& url, 64 const GURL& url,
64 const content::SSLStatus& ssl, 65 const content::SSLStatus& ssl,
65 bool show_history); 66 bool show_history,
67 content::PageNavigator* navigator);
66 68
67 // Shows the about dialog. See AboutChromeView. 69 // Shows the about dialog. See AboutChromeView.
68 views::Widget* ShowAboutChromeView(gfx::NativeWindow parent, 70 views::Widget* ShowAboutChromeView(gfx::NativeWindow parent,
69 Profile* profile); 71 Profile* profile);
70 72
71 // Creates and returns a find bar for the given browser window. See FindBarWin. 73 // Creates and returns a find bar for the given browser window. See FindBarWin.
72 FindBar* CreateFindBar(BrowserView* browser_view); 74 FindBar* CreateFindBar(BrowserView* browser_view);
73 75
74 // Shows the Task Manager. 76 // Shows the Task Manager.
75 void ShowTaskManager(); 77 void ShowTaskManager();
(...skipping 16 matching lines...) Expand all
92 TabContentsWrapper* tab_contents); 94 TabContentsWrapper* tab_contents);
93 95
94 // Shows the create chrome app shortcut dialog box. 96 // Shows the create chrome app shortcut dialog box.
95 void ShowCreateChromeAppShortcutsDialog(gfx::NativeWindow parent_window, 97 void ShowCreateChromeAppShortcutsDialog(gfx::NativeWindow parent_window,
96 Profile* profile, 98 Profile* profile,
97 const extensions::Extension* app); 99 const extensions::Extension* app);
98 100
99 } // namespace browser 101 } // namespace browser
100 102
101 #endif // CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_ 103 #endif // CHROME_BROWSER_UI_VIEWS_BROWSER_DIALOGS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/page_info_bubble.h ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698