Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/chromeos/login/simple_web_view_dialog.cc

Issue 10413061: Make PageInfoBubble not use BrowserList::GetLastActive and instead obtain a navigator at creation t… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/simple_web_view_dialog.cc
===================================================================
--- chrome/browser/chromeos/login/simple_web_view_dialog.cc (revision 138673)
+++ chrome/browser/chromeos/login/simple_web_view_dialog.cc (working copy)
@@ -254,6 +254,13 @@
}
}
+content::WebContents* SimpleWebViewDialog::OpenURL(
+ const content::OpenURLParams& params) {
+ // As there are no Browsers right now, this could not actually ever work.
+ NOTIMPLEMENTED();
+ return NULL;
+}
+
void SimpleWebViewDialog::LoadingStateChanged(WebContents* source) {
bool is_loading = source->IsLoading();
UpdateReload(is_loading, false);
@@ -286,7 +293,9 @@
new PageInfoBubbleView(
location_bar_->location_icon_view(),
location_bar_->profile(),
- url, ssl, true);
+ url, ssl,
+ true,
+ this);
page_info_bubble->set_parent_window(
ash::Shell::GetInstance()->GetContainer(
ash::internal::kShellWindowId_LockSystemModalContainer));
« no previous file with comments | « chrome/browser/chromeos/login/simple_web_view_dialog.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698