Improve the TLS intolerant server testing support added in r134129

Improve the TLS intolerant server testing support added in r134129
(http://codereview.chromium.org/10218007).

Add the ability to simulate a server that is intolerant of only a
particular version of TLS. This will allow us to test the handling
of a TLS 1.1 intolerant server.

R=agl@chromium.org,phajdan.jr@chromium.org
BUG=126340
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138537

[wtc, 2012-05-22 22:02:02]

Please review.  I will update
third_party/tlslite/patches/tls_intolerant.patch
after the code review is finished.  Thanks.

https://chromiumcodereview.appspot.com/10412042/diff/1/net/tools/testserver/t...
File net/tools/testserver/testserver.py (right):

https://chromiumcodereview.appspot.com/10412042/diff/1/net/tools/testserver/t...
net/tools/testserver/testserver.py:2179: option_parser.add_option('',
'--tls-intolerant', dest='tls_intolerant',

I am not familiar with Python.  I found that if I remove
    dest='tls_intolerant',
here, things still seem to work.  Do you know why?

[agl, 2012-05-22 22:07:11]

LGTM

https://chromiumcodereview.appspot.com/10412042/diff/1/net/tools/testserver/t...
File net/tools/testserver/testserver.py (right):

https://chromiumcodereview.appspot.com/10412042/diff/1/net/tools/testserver/t...
net/tools/testserver/testserver.py:2179: option_parser.add_option('',
'--tls-intolerant', dest='tls_intolerant',
On 2012/05/22 22:02:02, wtc wrote:
> 
> I am not familiar with Python.  I found that if I remove
>     dest='tls_intolerant',
> here, things still seem to work.  Do you know why?

According to:

http://docs.python.org/library/optparse.html#the-store-action

The default destination is built by replacing hyphens with underscores in the
long-form argument. So dest can be safely omitted in this option.

[commit-bot: I haz the power, 2012-05-23 01:15:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/10412042/13001

[commit-bot: I haz the power, 2012-05-23 05:51:22]

Try job failure for 10412042-13001 (previous was lost) (retry) (retry) on
win_rel for step "runhooks".
It's a second try, previously, step "sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Paweł Hajdan Jr., 2012-05-23 06:35:07]

LGTM

Please make sure to submit any custom tlslite patches upstream.

[commit-bot: I haz the power, 2012-05-23 13:01:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/10412042/13001

[commit-bot: I haz the power, 2012-05-23 18:32:26]

Change committed as 138537