Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2424)

Unified Diff: net/test/base_test_server.cc

Issue 10412042: Improve the TLS intolerant server testing support added in r134129 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Tweak enumerator names Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/test/base_test_server.h ('k') | net/tools/testserver/testserver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/base_test_server.cc
===================================================================
--- net/test/base_test_server.cc (revision 138367)
+++ net/test/base_test_server.cc (working copy)
@@ -59,7 +59,7 @@
request_client_certificate(false),
bulk_ciphers(HTTPSOptions::BULK_CIPHER_ANY),
record_resume(false),
- tls_intolerant(false) {}
+ tls_intolerant(TLS_INTOLERANT_NONE) {}
BaseTestServer::HTTPSOptions::HTTPSOptions(
BaseTestServer::HTTPSOptions::ServerCertificate cert)
@@ -67,7 +67,7 @@
request_client_certificate(false),
bulk_ciphers(HTTPSOptions::BULK_CIPHER_ANY),
record_resume(false),
- tls_intolerant(false) {}
+ tls_intolerant(TLS_INTOLERANT_NONE) {}
BaseTestServer::HTTPSOptions::~HTTPSOptions() {}
@@ -377,8 +377,10 @@
arguments->Set("ssl-bulk-cipher", bulk_cipher_values.release());
if (https_options_.record_resume)
arguments->Set("https-record-resume", base::Value::CreateNullValue());
- if (https_options_.tls_intolerant)
- arguments->Set("tls-intolerant", base::Value::CreateNullValue());
+ if (https_options_.tls_intolerant != HTTPSOptions::TLS_INTOLERANT_NONE) {
+ arguments->Set("tls-intolerant",
+ base::Value::CreateIntegerValue(https_options_.tls_intolerant));
+ }
}
return true;
}
« no previous file with comments | « net/test/base_test_server.h ('k') | net/tools/testserver/testserver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698