Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 10412042: Improve the TLS intolerant server testing support added in r134129 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Tweak enumerator names Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/testserver/testserver.py ('k') | third_party/tlslite/patches/tls_intolerant.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
===================================================================
--- net/url_request/url_request_unittest.cc (revision 138367)
+++ net/url_request/url_request_unittest.cc (working copy)
@@ -1728,7 +1728,7 @@
TEST_F(HTTPSRequestTest, SSLv3Fallback) {
TestServer::HTTPSOptions https_options(
TestServer::HTTPSOptions::CERT_OK);
- https_options.tls_intolerant = true;
+ https_options.tls_intolerant = TestServer::HTTPSOptions::TLS_INTOLERANT_ALL;
TestServer test_server(https_options,
FilePath(FILE_PATH_LITERAL("net/data/ssl")));
ASSERT_TRUE(test_server.Start());
@@ -1745,6 +1745,8 @@
EXPECT_EQ(1, d.response_started_count());
EXPECT_NE(0, d.bytes_received());
+ EXPECT_EQ(SSL_CONNECTION_VERSION_SSL3,
+ SSLConnectionStatusToVersion(r.ssl_info().connection_status));
EXPECT_TRUE(r.ssl_info().connection_status & SSL_CONNECTION_SSL3_FALLBACK);
}
« no previous file with comments | « net/tools/testserver/testserver.py ('k') | third_party/tlslite/patches/tls_intolerant.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698