Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed)

Created:
8 years, 7 months ago by jam
Modified:
8 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, jochen+watch-content_chromium.org, kkania, yoshiki+watch_chromium.org, ajwong+watch_chromium.org, jam, ben+watch_chromium.org, sadrul, joi+watch-content_chromium.org, Aaron Boodman, Satish, darin-cc_chromium.org, brettw-cc_chromium.org, robertshield
Visibility:
Public.

Description

Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum value in the WebContents' property bag. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138434

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : review comments #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -299 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_util.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 2 4 chunks +4 lines, -4 lines 2 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_host_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 2 13 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_webkit_preferences.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webkit_preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 2 4 chunks +32 lines, -36 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 1 2 3 chunks +18 lines, -15 lines 2 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_util.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/panel_view_aura.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
A chrome/browser/view_type_utils.h View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/view_type_utils.cc View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/chrome_view_type.h View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/common/chrome_view_type.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
A + chrome/common/view_type.h View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
A + chrome/common/view_type.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 2 7 chunks +8 lines, -8 lines 0 comments Download
M content/browser/web_contents/interstitial_page_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 4 chunks +1 line, -14 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/render_view_host_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/browser/web_contents.h View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
D content/public/common/view_type.h View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
8 years, 7 months ago (2012-05-23 01:59:49 UTC) #1
Avi (use Gerrit)
"Get rid of the RenderViewType concept in Chrome" > "Get rid of the RenderViewType concept ...
8 years, 7 months ago (2012-05-23 03:14:32 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/10409088/diff/14004/chrome/browser/automation/automation_util.cc File chrome/browser/automation/automation_util.cc (right): http://codereview.chromium.org/10409088/diff/14004/chrome/browser/automation/automation_util.cc#newcode419 chrome/browser/automation/automation_util.cc:419: const_cast<RenderViewHost*>(render_view_host)); Eeeewww. Can you please fix FromRenderViewHost to take ...
8 years, 7 months ago (2012-05-23 03:22:46 UTC) #3
jam
http://codereview.chromium.org/10409088/diff/14004/chrome/browser/automation/automation_util.cc File chrome/browser/automation/automation_util.cc (right): http://codereview.chromium.org/10409088/diff/14004/chrome/browser/automation/automation_util.cc#newcode419 chrome/browser/automation/automation_util.cc:419: const_cast<RenderViewHost*>(render_view_host)); On 2012/05/23 03:22:52, Avi wrote: > Eeeewww. Can ...
8 years, 7 months ago (2012-05-23 04:18:38 UTC) #4
Avi (use Gerrit)
LGTM when you fix noted nits. http://codereview.chromium.org/10409088/diff/6006/chrome/browser/extensions/extension_host.h File chrome/browser/extensions/extension_host.h (right): http://codereview.chromium.org/10409088/diff/6006/chrome/browser/extensions/extension_host.h#newcode21 chrome/browser/extensions/extension_host.h:21: #include "chrome/common/view_type.h" alphabetize ...
8 years, 7 months ago (2012-05-23 04:40:35 UTC) #5
jam
8 years, 7 months ago (2012-05-23 05:08:15 UTC) #6 
http://codereview.chromium.org/10409088/diff/6006/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_host.h (right):

http://codereview.chromium.org/10409088/diff/6006/chrome/browser/extensions/e...
chrome/browser/extensions/extension_host.h:21: #include
"chrome/common/view_type.h"
On 2012/05/23 04:40:35, Avi wrote:
> alphabetize

Done.

http://codereview.chromium.org/10409088/diff/6006/chrome/browser/speech/chrom...
File chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
(right):

http://codereview.chromium.org/10409088/diff/6006/chrome/browser/speech/chrom...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:313:
content::RenderViewHost* render_view_host =
On 2012/05/23 04:40:35, Avi wrote:
> Since you fixed FromRenderViewHost you could leave the const.

Done.

Powered by Google App Engine
This is Rietveld 408576698