Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/task_manager/task_manager_resource_providers.cc

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_manager/task_manager_resource_providers.h" 5 #include "chrome/browser/task_manager/task_manager_resource_providers.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 19 matching lines...) Expand all
30 #include "chrome/browser/prerender/prerender_manager.h" 30 #include "chrome/browser/prerender/prerender_manager.h"
31 #include "chrome/browser/prerender/prerender_manager_factory.h" 31 #include "chrome/browser/prerender/prerender_manager_factory.h"
32 #include "chrome/browser/profiles/profile.h" 32 #include "chrome/browser/profiles/profile.h"
33 #include "chrome/browser/profiles/profile_info_cache.h" 33 #include "chrome/browser/profiles/profile_info_cache.h"
34 #include "chrome/browser/profiles/profile_manager.h" 34 #include "chrome/browser/profiles/profile_manager.h"
35 #include "chrome/browser/tab_contents/background_contents.h" 35 #include "chrome/browser/tab_contents/background_contents.h"
36 #include "chrome/browser/tab_contents/tab_util.h" 36 #include "chrome/browser/tab_contents/tab_util.h"
37 #include "chrome/browser/ui/browser.h" 37 #include "chrome/browser/ui/browser.h"
38 #include "chrome/browser/ui/browser_list.h" 38 #include "chrome/browser/ui/browser_list.h"
39 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 39 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
40 #include "chrome/browser/view_type_utils.h"
40 #include "chrome/common/chrome_notification_types.h" 41 #include "chrome/common/chrome_notification_types.h"
41 #include "chrome/common/chrome_switches.h" 42 #include "chrome/common/chrome_switches.h"
42 #include "chrome/common/chrome_view_type.h"
43 #include "chrome/common/extensions/extension.h" 43 #include "chrome/common/extensions/extension.h"
44 #include "chrome/common/render_messages.h" 44 #include "chrome/common/render_messages.h"
45 #include "chrome/common/url_constants.h" 45 #include "chrome/common/url_constants.h"
46 #include "content/public/browser/browser_child_process_host_iterator.h" 46 #include "content/public/browser/browser_child_process_host_iterator.h"
47 #include "content/public/browser/browser_thread.h" 47 #include "content/public/browser/browser_thread.h"
48 #include "content/public/browser/child_process_data.h" 48 #include "content/public/browser/child_process_data.h"
49 #include "content/public/browser/notification_service.h" 49 #include "content/public/browser/notification_service.h"
50 #include "content/public/browser/render_process_host.h" 50 #include "content/public/browser/render_process_host.h"
51 #include "content/public/browser/render_view_host.h" 51 #include "content/public/browser/render_view_host.h"
52 #include "content/public/browser/render_view_host_delegate.h"
53 #include "content/public/browser/web_contents.h" 52 #include "content/public/browser/web_contents.h"
54 #include "content/public/common/process_type.h" 53 #include "content/public/common/process_type.h"
55 #include "content/public/common/view_type.h"
56 #include "grit/generated_resources.h" 54 #include "grit/generated_resources.h"
57 #include "grit/theme_resources.h" 55 #include "grit/theme_resources.h"
58 #include "grit/theme_resources_standard.h" 56 #include "grit/theme_resources_standard.h"
59 #include "third_party/sqlite/sqlite3.h" 57 #include "third_party/sqlite/sqlite3.h"
60 #include "ui/base/l10n/l10n_util.h" 58 #include "ui/base/l10n/l10n_util.h"
61 #include "ui/base/resource/resource_bundle.h" 59 #include "ui/base/resource/resource_bundle.h"
62 #include "v8/include/v8.h" 60 #include "v8/include/v8.h"
63 61
64 #if defined(OS_MACOSX) 62 #if defined(OS_MACOSX)
65 #include "skia/ext/skia_utils_mac.h" 63 #include "skia/ext/skia_utils_mac.h"
(...skipping 1135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1201 1199
1202 const Extension* TaskManagerExtensionProcessResource::GetExtension() const { 1200 const Extension* TaskManagerExtensionProcessResource::GetExtension() const {
1203 Profile* profile = Profile::FromBrowserContext( 1201 Profile* profile = Profile::FromBrowserContext(
1204 render_view_host_->GetProcess()->GetBrowserContext()); 1202 render_view_host_->GetProcess()->GetBrowserContext());
1205 ExtensionProcessManager* process_manager = 1203 ExtensionProcessManager* process_manager =
1206 ExtensionSystem::Get(profile)->process_manager(); 1204 ExtensionSystem::Get(profile)->process_manager();
1207 return process_manager->GetExtensionForRenderViewHost(render_view_host_); 1205 return process_manager->GetExtensionForRenderViewHost(render_view_host_);
1208 } 1206 }
1209 1207
1210 bool TaskManagerExtensionProcessResource::IsBackground() const { 1208 bool TaskManagerExtensionProcessResource::IsBackground() const {
1211 return render_view_host_->GetDelegate()->GetRenderViewType() == 1209 WebContents* web_contents =
1212 chrome::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE; 1210 WebContents::FromRenderViewHost(render_view_host_);
1211 chrome::ViewType view_type = chrome::GetViewType(web_contents);
1212 return view_type == chrome::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
1213 } 1213 }
1214 1214
1215 //////////////////////////////////////////////////////////////////////////////// 1215 ////////////////////////////////////////////////////////////////////////////////
1216 // TaskManagerExtensionProcessResourceProvider class 1216 // TaskManagerExtensionProcessResourceProvider class
1217 //////////////////////////////////////////////////////////////////////////////// 1217 ////////////////////////////////////////////////////////////////////////////////
1218 1218
1219 TaskManagerExtensionProcessResourceProvider:: 1219 TaskManagerExtensionProcessResourceProvider::
1220 TaskManagerExtensionProcessResourceProvider(TaskManager* task_manager) 1220 TaskManagerExtensionProcessResourceProvider(TaskManager* task_manager)
1221 : task_manager_(task_manager), 1221 : task_manager_(task_manager),
1222 updating_(false) { 1222 updating_(false) {
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 NOTREACHED() << "Unexpected notification."; 1323 NOTREACHED() << "Unexpected notification.";
1324 return; 1324 return;
1325 } 1325 }
1326 } 1326 }
1327 1327
1328 bool TaskManagerExtensionProcessResourceProvider:: 1328 bool TaskManagerExtensionProcessResourceProvider::
1329 IsHandledByThisProvider(content::RenderViewHost* render_view_host) { 1329 IsHandledByThisProvider(content::RenderViewHost* render_view_host) {
1330 // Don't add WebContents (those are handled by 1330 // Don't add WebContents (those are handled by
1331 // TaskManagerTabContentsResourceProvider) or background contents (handled 1331 // TaskManagerTabContentsResourceProvider) or background contents (handled
1332 // by TaskManagerBackgroundResourceProvider). 1332 // by TaskManagerBackgroundResourceProvider).
1333 content::ViewType view_type = 1333 WebContents* web_contents = WebContents::FromRenderViewHost(render_view_host);
1334 render_view_host->GetDelegate()->GetRenderViewType(); 1334 chrome::ViewType view_type = chrome::GetViewType(web_contents);
1335 return (view_type != chrome::VIEW_TYPE_TAB_CONTENTS && 1335 return (view_type != chrome::VIEW_TYPE_TAB_CONTENTS &&
1336 view_type != chrome::VIEW_TYPE_BACKGROUND_CONTENTS); 1336 view_type != chrome::VIEW_TYPE_BACKGROUND_CONTENTS);
1337 } 1337 }
1338 1338
1339 void TaskManagerExtensionProcessResourceProvider::AddToTaskManager( 1339 void TaskManagerExtensionProcessResourceProvider::AddToTaskManager(
1340 content::RenderViewHost* render_view_host) { 1340 content::RenderViewHost* render_view_host) {
1341 if (!IsHandledByThisProvider(render_view_host)) 1341 if (!IsHandledByThisProvider(render_view_host))
1342 return; 1342 return;
1343 1343
1344 TaskManagerExtensionProcessResource* resource = 1344 TaskManagerExtensionProcessResource* resource =
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1505 1505
1506 return &resource_; 1506 return &resource_;
1507 } 1507 }
1508 1508
1509 void TaskManagerBrowserProcessResourceProvider::StartUpdating() { 1509 void TaskManagerBrowserProcessResourceProvider::StartUpdating() {
1510 task_manager_->AddResource(&resource_); 1510 task_manager_->AddResource(&resource_);
1511 } 1511 }
1512 1512
1513 void TaskManagerBrowserProcessResourceProvider::StopUpdating() { 1513 void TaskManagerBrowserProcessResourceProvider::StopUpdating() {
1514 } 1514 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698