chrome/browser/ui/gtk/extensions/extension_view_gtk.cc - Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/extension_view_gtk.cc

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc ('K') | « chrome/browser/ui/extensions/shell_window.cc ('k') | chrome/browser/ui/tab_contents/tab_contents_wrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/extensions/extension_view_gtk.cc

===================================================================

--- chrome/browser/ui/gtk/extensions/extension_view_gtk.cc (revision 138369)

+++ chrome/browser/ui/gtk/extensions/extension_view_gtk.cc (working copy)

@@ -6,7 +6,7 @@

#include "chrome/browser/extensions/extension_host.h"

#include "chrome/browser/ui/gtk/extensions/extension_popup_gtk.h"

-#include "chrome/common/chrome_view_type.h"

+#include "chrome/common/view_type.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/web_contents.h"

@@ -54,7 +54,7 @@

pending_background_.reset();

}

- content::ViewType host_type = extension_host_->extension_host_type();

+ chrome::ViewType host_type = extension_host_->extension_host_type();

if (host_type == chrome::VIEW_TYPE_EXTENSION_POPUP) {

gfx::Size min_size(ExtensionPopupGtk::kMinWidth,

ExtensionPopupGtk::kMinHeight);