Issue 10398060: Base: Crash the process if we are not able to join threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10398060: Base: Crash the process if we are not able to join threads. (Closed)

Created:
8 years, 7 months ago by rvargas (doing something else)

Modified:
8 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Base: Crash the process if we are not able to join threads. BUG=127931 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137541

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	base/threading/platform_thread_win.cc	View		1 chunk	+7 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

lgtm https://chromiumcodereview.appspot.com/10398060/diff/1/base/threading/platform_thread_win.cc File base/threading/platform_thread_win.cc (right): https://chromiumcodereview.appspot.com/10398060/diff/1/base/threading/platform_thread_win.cc#newcode184 base/threading/platform_thread_win.cc:184: if (result != WAIT_OBJECT_0) { Should we alias ...

8 years, 7 months ago (2012-05-16 20:15:50 UTC) #2

Thanks, all done.

Expand Messages | Collapse Messages