Base: Crash the process if we are not able to join threads.

base/threading/platform_thread_win.cc

Index: base/threading/platform_thread_win.cc
===================================================================
--- base/threading/platform_thread_win.cc	(revision 137046)
+++ base/threading/platform_thread_win.cc	(working copy)
@@ -181,7 +181,13 @@
   // Wait for the thread to exit.  It should already have terminated but make
   // sure this assumption is valid.
   DWORD result = WaitForSingleObject(thread_handle, INFINITE);
-  DCHECK_EQ(WAIT_OBJECT_0, result);
+  if (result != WAIT_OBJECT_0) {

[willchan no longer on Chromium, 2012/05/16 20:15:50]

Should we alias &result too?

+    // Debug info for bug 127931.
+    DWORD error = GetLastError();
+    debug::Alias(&error);
+    debug::Alias(&thread_handle);
+    CHECK(false) << "Failed to wait for thread";

[willchan no longer on Chromium, 2012/05/16 20:15:50]

I'd be inclined to ditch the string since it bloats the release binary. I think
the line number is good enough. Up to you.

+  }
 
   CloseHandle(thread_handle);
 }