Base: Crash the process if we are not able to join threads.

base/threading/platform_thread_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/platform_thread.h"
 
 #include "base/debug/alias.h"
 #include "base/logging.h"
 #include "base/threading/thread_local.h"
 #include "base/threading/thread_restrictions.h"
@@ skipping 163 matching lines @@
   // Joining another thread may block the current thread for a long time, since
   // the thread referred to by |thread_handle| may still be running long-lived /
   // blocking tasks.
 #if 0
   base::ThreadRestrictions::AssertIOAllowed();
 #endif
 
   // Wait for the thread to exit.  It should already have terminated but make
   // sure this assumption is valid.
   DWORD result = WaitForSingleObject(thread_handle, INFINITE);
-  DCHECK_EQ(WAIT_OBJECT_0, result);
+  if (result != WAIT_OBJECT_0) {

[willchan no longer on Chromium, 2012/05/16 20:15:50]

Should we alias &result too?

+    // Debug info for bug 127931.
+    DWORD error = GetLastError();
+    debug::Alias(&error);
+    debug::Alias(&thread_handle);
+    CHECK(false) << "Failed to wait for thread";

[willchan no longer on Chromium, 2012/05/16 20:15:50]

I'd be inclined to ditch the string since it bloats the release binary. I think
the line number is good enough. Up to you.

+  }
 
   CloseHandle(thread_handle);
 }
 
 // static
 void PlatformThread::SetThreadPriority(PlatformThreadHandle handle,
                                        ThreadPriority priority) {
   switch (priority) {
     case kThreadPriority_Normal:
       ::SetThreadPriority(handle, THREAD_PRIORITY_NORMAL);
       break;
     case kThreadPriority_RealtimeAudio:
       ::SetThreadPriority(handle, THREAD_PRIORITY_TIME_CRITICAL);
       break;
   }
 }
 
 }  // namespace base