Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 10392139: Merge 115471 - Infinite backgroundClipRect should not be scrolled. (Closed)

Created:
8 years, 7 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 7 months ago
Reviewers:
shawnsingh
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 115471 - Infinite backgroundClipRect should not be scrolled. https://bugs.webkit.org/show_bug.cgi?id=84979 Reviewed by Adrienne Walker. Source/WebCore: Test: compositing/iframes/scroll-fixed-transformed-element.html By accidentally scrolling clipRects that should be considered "infinite", they were no longer being considered infinite. This caused a chain of un-intended code paths that caused fixed position elements to stutter when scrolling in Chromium. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::backgroundClipRect): LayoutTests: * compositing/iframes/resources/fixed-position-transformed-subframe.html: Added. * compositing/iframes/scroll-fixed-transformed-element-expected.png: Added. * compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added. * compositing/iframes/scroll-fixed-transformed-element.html: Added. TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --3 lines) Patch
A + LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/iframes/scroll-fixed-transformed-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/iframes/scroll-fixed-transformed-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Mihai Parparita -not on Chrome
8 years, 7 months ago (2012-05-16 22:45:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698