Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 10392127: Move declarative API into events API (Closed)

Created:
8 years, 7 months ago by battre
Modified:
8 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move declarative API into events API The motivation of this CL is to bring the declarative API and the rest of the events mechanism closer together in the API documentation. To achive this, we move the content of declarative.json and everything related to events from extension.json into the events.json API definition. The new "events" namespace is automatically provided to all extensions. This is a second attempt after http://src.chromium.org/viewvc/chrome?view=rev&revision=137388 failed in ExecuteScriptApiTest.ExecuteScriptInFrame. TBR'ing as this is a tiny change from the previous CL. BUG=126497, 112155 TEST=no TBR=aa@chromium.org, kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137406

Patch Set 1 #

Patch Set 2 : Fix change schema type reference from 'Event' to 'events.Event' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1592 lines, -2118 lines) Patch
M chrome/browser/extensions/api/declarative/declarative_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/declarative.json View 1 chunk +0 lines, -236 lines 0 comments Download
M chrome/common/extensions/api/declarative_web_request.json View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/api/events.json View 2 chunks +108 lines, -97 lines 0 comments Download
M chrome/common/extensions/api/extension.json View 1 2 chunks +3 lines, -15 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/api_index.html View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/declarative.html View 1 chunk +0 lines, -1314 lines 0 comments Download
M chrome/common/extensions/docs/declarativeWebRequest.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/events.html View 4 chunks +1160 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/extension.html View 4 chunks +2 lines, -135 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 2 chunks +7 lines, -3 lines 0 comments Download
D chrome/common/extensions/docs/static/declarative.html View 1 chunk +0 lines, -140 lines 0 comments Download
M chrome/common/extensions/docs/static/declarativeWebRequest.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/events.html View 1 chunk +122 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/api_definitions_natives.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/api_definitions_natives.cc View 2 chunks +28 lines, -1 line 0 comments Download
M chrome/renderer/extensions/event_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 2 chunks +1 line, -1 line 0 comments Download
D chrome/renderer/resources/extensions/declarative_custom_bindings.js View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/event.js View 5 chunks +82 lines, -30 lines 0 comments Download
M chrome/renderer/resources/extensions/schema_generated_bindings.js View 3 chunks +5 lines, -8 lines 0 comments Download
A chrome/renderer/resources/extensions/utils.js View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/web_request_custom_bindings.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/declarative/api/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/json_schema_compiler/h_generator.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
battre
8 years, 7 months ago (2012-05-16 11:48:17 UTC) #1
I'll just reland this and TBR you. I have verified that the bugs are gone
locally. The try bots did not catch the problem before, so I don't expect them
to catch it this time.

Powered by Google App Engine
This is Rietveld 408576698