chrome/renderer/resources/extensions/web_request_custom_bindings.js - Issue 10392127: Move declarative API into events API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_request_custom_bindings.js

Issue 10392127: Move declarative API into events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix change schema type reference from 'Event' to 'events.Event' Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/utils.js ('k') | chrome/test/data/extensions/api_test/declarative/api/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/web_request_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/web_request_custom_bindings.js b/chrome/renderer/resources/extensions/web_request_custom_bindings.js

index a0e00e85efd2592a34f0f7cd84be2a57f65f0bb6..527af0cde7cac1f092af91a71a870ccff4b02d6d 100644

--- a/chrome/renderer/resources/extensions/web_request_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/web_request_custom_bindings.js

@@ -32,9 +32,10 @@ function WebRequestEvent(eventName, opt_argSchemas, opt_extraArgSchemas,

this.eventOptions_ = opt_eventOptions ||

{'supportsListeners': true, 'supportsRules': false};

- if (this.eventOptions_.supportsRules)

+ if (this.eventOptions_.supportsRules) {

this.eventForRules_ =

new chrome.Event(eventName, opt_argSchemas, opt_eventOptions);

+ }

};

// Test if the given callback is registered for this event.