Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5663)

Unified Diff: chrome/renderer/extensions/api_definitions_natives.cc

Issue 10392127: Move declarative API into events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix change schema type reference from 'Event' to 'events.Event' Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/api_definitions_natives.h ('k') | chrome/renderer/extensions/event_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/api_definitions_natives.cc
diff --git a/chrome/renderer/extensions/api_definitions_natives.cc b/chrome/renderer/extensions/api_definitions_natives.cc
index bc8b4b0f9ea0a3642a8358184f5732628f505ab9..2bcbc28a6bb9c5d592161b04cb6e0e27025e6ffc 100644
--- a/chrome/renderer/extensions/api_definitions_natives.cc
+++ b/chrome/renderer/extensions/api_definitions_natives.cc
@@ -4,6 +4,12 @@
#include "chrome/renderer/extensions/api_definitions_natives.h"
+#include <algorithm>
+
+namespace {
+const char kInvalidExtensionNamespace[] = "Invalid extension namespace";
+}
+
namespace extensions {
ApiDefinitionsNatives::ApiDefinitionsNatives(
@@ -19,8 +25,29 @@ v8::Handle<v8::Value> ApiDefinitionsNatives::GetExtensionAPIDefinition(
ChromeV8Context* v8_context =
extension_dispatcher()->v8_context_set().GetCurrent();
CHECK(v8_context);
+
+ std::set<std::string> available_apis(v8_context->GetAvailableExtensionAPIs());
+ if (args.Length() == 0) {
+ return extension_dispatcher()->v8_schema_registry()->GetSchemas(
+ available_apis);
+ }
+ // Build set of APIs requested by the user.
+ std::set<std::string> requested_apis;
+ for (int i = 0; i < args.Length(); ++i) {
+ if (!args[i]->IsString()) {
+ v8::ThrowException(v8::String::New(kInvalidExtensionNamespace));
+ return v8::Undefined();
+ }
+ requested_apis.insert(*v8::String::Utf8Value(args[i]->ToString()));
+ }
+
+ // Filter those that are unknown.
+ std::set<std::string> apis_to_check;
+ std::set_intersection(requested_apis.begin(), requested_apis.end(),
+ available_apis.begin(), available_apis.end(),
+ std::inserter(apis_to_check, apis_to_check.begin()));
return extension_dispatcher()->v8_schema_registry()->GetSchemas(
- v8_context->GetAvailableExtensionAPIs());
+ apis_to_check);
}
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/api_definitions_natives.h ('k') | chrome/renderer/extensions/event_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698