Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 10392072: Pass the render view host with all provisional load related callbacks on the web contents observer (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, tburkard+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

Pass the render view host with all provisional load related callbacks on the web contents observer There might be several provisional loads in different render view hosts going on, so the observers need to know where the signals came from BUG=109792 TEST=none, just added the parameter everywhere Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137534

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -21 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/external_tab/external_tab_container_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab/external_tab_container_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 4 chunks +7 lines, -4 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
Avi & Charlie, please review
8 years, 7 months ago (2012-05-13 07:02:31 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 7 months ago (2012-05-13 14:26:32 UTC) #2
Charlie Reis
LGTM. Do you have any plans yet for how to use that information? Can you ...
8 years, 7 months ago (2012-05-14 18:29:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10392072/1
8 years, 7 months ago (2012-05-16 19:26:18 UTC) #4
commit-bot: I haz the power
Can't apply patch for file content/browser/browser_plugin/browser_plugin_web_contents_observer.cc. While running patch -p1 --forward --force; patching file content/browser/browser_plugin/browser_plugin_web_contents_observer.cc ...
8 years, 7 months ago (2012-05-16 19:26:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10392072/11001
8 years, 7 months ago (2012-05-16 20:07:18 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 22:13:49 UTC) #7
Change committed as 137534

Powered by Google App Engine
This is Rietveld 408576698