chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 10392072: Pass the render view host with all provisional load related callbacks on the web contents observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 10392072: Pass the render view host with all provisional load related callbacks on the web contents observer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.h ('k') | chrome/browser/external_tab/external_tab_container_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

index e7978191a2ee1d16e7b8d7f7a9a41df5d5be22d3..0c7af7dc54de6b1629c4e2e5ff724ffcd93d367d 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

@@ -585,7 +585,8 @@ void WebNavigationTabObserver::DidCommitProvisionalLoadForFrame(

int64 frame_id,

bool is_main_frame,

const GURL& url,

- content::PageTransition transition_type) {

+ content::PageTransition transition_type,

+ content::RenderViewHost* render_view_host) {

if (!navigation_state_.CanSendEvents(frame_id))

return;

@@ -625,7 +626,8 @@ void WebNavigationTabObserver::DidFailProvisionalLoad(

bool is_main_frame,

const GURL& validated_url,

int error_code,

- const string16& error_description) {

+ const string16& error_description,

+ content::RenderViewHost* render_view_host) {

if (!navigation_state_.CanSendEvents(frame_id))

return;

navigation_state_.SetErrorOccurredInFrame(frame_id);