chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 10392072: Pass the render view host with all provisional load related callbacks on the web contents observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 10392072: Pass the render view host with all provisional load related callbacks on the web contents observer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

index 6cdef16ca2274f5b7ad0c3e5c793864b4d172557..b5a3c964a5bb10af628b20322527dcd8d908420a 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

@@ -156,13 +156,15 @@ class WebNavigationTabObserver : public content::NotificationObserver,

int64 frame_id,

bool is_main_frame,

const GURL& url,

- content::PageTransition transition_type) OVERRIDE;

+ content::PageTransition transition_type,

+ content::RenderViewHost* render_view_host) OVERRIDE;

virtual void DidFailProvisionalLoad(

int64 frame_id,

bool is_main_frame,

const GURL& validated_url,

int error_code,

- const string16& error_description) OVERRIDE;

+ const string16& error_description,

+ content::RenderViewHost* render_view_host) OVERRIDE;

virtual void DocumentLoadedInFrame(int64 frame_id) OVERRIDE;

virtual void DidFinishLoad(int64 frame_id,

const GURL& validated_url,

« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | no next file with comments »