Add alternative path for breakpad dump location.

Add alternative path for breakpad dump location.

If "BREAKPAD_DUMP_LOCATION" environment variable is set, use this path instead.  Currently Mac's breakpad uses this to specify alternative path for breakpad dump location.  For Chromebot this allows crashes to be identified with multiple Chrome instances.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137587

[cmp, 2012-05-16 22:21:01]

lgtm, +thestig and phajdan in case they're interested

[Lei Zhang, 2012-05-16 22:28:14]

This should be fine, but you'll need the other platforms to honor
BREAKPAD_DUMP_LOCATION.

[chrisphan1, 2012-05-16 22:29:09]

On 2012/05/16 22:28:14, Lei Zhang wrote:
> This should be fine, but you'll need the other platforms to honor
> BREAKPAD_DUMP_LOCATION.

I'll update those soon.

[commit-bot: I haz the power, 2012-05-16 22:50:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisphan@chromium.org/10391175/3001

[commit-bot: I haz the power, 2012-05-17 00:47:19]

Change committed as 137587

[Paweł Hajdan Jr., 2012-05-17 14:54:45]

https://chromiumcodereview.appspot.com/10391175/diff/3001/page_load_test.cc
File page_load_test.cc (right):

https://chromiumcodereview.appspot.com/10391175/diff/3001/page_load_test.cc#n...
page_load_test.cc:643: PathService::Get(chrome::DIR_CRASH_DUMPS,
&crash_dumps_dir_path_);
Wait, shouldn't you modify the PathService code for DIR_CRASH_DUMPS to honor
BREAKPAD_DUMP_LOCATION?

Putting this logic on the caller side seems brittle, and may even cause code
duplication.

[chrisphan1, 2012-05-17 18:18:54]

https://chromiumcodereview.appspot.com/10391175/diff/3001/page_load_test.cc
File page_load_test.cc (right):

https://chromiumcodereview.appspot.com/10391175/diff/3001/page_load_test.cc#n...
page_load_test.cc:643: PathService::Get(chrome::DIR_CRASH_DUMPS,
&crash_dumps_dir_path_);
On 2012/05/17 14:54:45, Paweł Hajdan Jr. wrote:
> Wait, shouldn't you modify the PathService code for DIR_CRASH_DUMPS to honor
> BREAKPAD_DUMP_LOCATION?
> 
> Putting this logic on the caller side seems brittle, and may even cause code
> duplication.

DIR_CRASH_DUMPS gets modified in the breakpad at the moment.  Should I go ahead
and modified here instead?

[Paweł Hajdan Jr., 2012-05-21 08:30:57]

https://chromiumcodereview.appspot.com/10391175/diff/3001/page_load_test.cc
File page_load_test.cc (right):

https://chromiumcodereview.appspot.com/10391175/diff/3001/page_load_test.cc#n...
page_load_test.cc:643: PathService::Get(chrome::DIR_CRASH_DUMPS,
&crash_dumps_dir_path_);
On 2012/05/17 18:18:55, chrisphan1 wrote:
> On 2012/05/17 14:54:45, Paweł Hajdan Jr. wrote:
> > Wait, shouldn't you modify the PathService code for DIR_CRASH_DUMPS to honor
> > BREAKPAD_DUMP_LOCATION?
> > 
> > Putting this logic on the caller side seems brittle, and may even cause code
> > duplication.
> 
> DIR_CRASH_DUMPS gets modified in the breakpad at the moment.  Should I go
ahead
> and modified here instead?

Could you explain more? I suggested modifying PathService code for
DIR_CRASH_DUMPS, instead of patching it in just _one_ place that calls
PathService (and other users of DIR_CRASH_DUMPS do not get this change).