Add alternative path for breakpad dump location.

page_load_test.cc

Index: page_load_test.cc
===================================================================
--- page_load_test.cc	(revision 137530)
+++ page_load_test.cc	(working copy)
@@ -36,10 +36,12 @@
 #include <vector>
 
 #include "base/command_line.h"
+#include "base/environment.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/file_version_info.h"
 #include "base/i18n/time_formatting.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
@@ -631,8 +633,16 @@
     UITest::SetUp();
     g_browser_existing = true;
 
-    // Initialize crash_dumps_dir_path_.
-    PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dumps_dir_path_);
+    // If 'BREAKPAD_DUMP_LOCATION' environment variable is set, use it instead.
+    scoped_ptr<base::Environment> env(base::Environment::Create());
+    std::string alternate_minidump_location;
+    if (env->GetVar("BREAKPAD_DUMP_LOCATION", &alternate_minidump_location)) {
+      crash_dumps_dir_path_ = FilePath::FromUTF8Unsafe(
+          alternate_minidump_location);
+    } else {
+      PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dumps_dir_path_);

[Paweł Hajdan Jr., 2012/05/17 14:54:45]

Wait, shouldn't you modify the PathService code for DIR_CRASH_DUMPS to honor
BREAKPAD_DUMP_LOCATION?

Putting this logic on the caller side seems brittle, and may even cause code
duplication.

[chrisphan1, 2012/05/17 18:18:55]

DIR_CRASH_DUMPS gets modified in the breakpad at the moment.  Should I go ahead
and modified here instead?

[Paweł Hajdan Jr., 2012/05/21 08:30:57]

Could you explain more? I suggested modifying PathService code for
DIR_CRASH_DUMPS, instead of patching it in just _one_ place that calls
PathService (and other users of DIR_CRASH_DUMPS do not get this change).

+    }
+
     file_util::FileEnumerator enumerator(crash_dumps_dir_path_,
                                          false,  // not recursive
                                          file_util::FileEnumerator::FILES);