Add alternative path for breakpad dump location.

page_load_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file provides reliablity test which runs under UI test framework. The
 // test is intended to run within QEMU environment.
 //
 // Usage 1: reliability_test
 // Upon invocation, it visits a hard coded list of sample URLs. This is mainly
 // used by buildbot, to verify reliability_test itself runs ok.
@@ skipping 18 matching lines @@
 // --endurl=url: visits the specified url in the end.
 // --logfile=filepath: saves the visit log to the specified path.
 // --nopagedown: won't simulate page down key presses after page load.
 // --noclearprofile: do not clear profile dir before firing up each time.
 // --savedebuglog: save Chrome, V8, and test debug log for each page loaded.
 
 #include <fstream>
 #include <vector>
 
 #include "base/command_line.h"
+#include "base/environment.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/file_version_info.h"
 #include "base/i18n/time_formatting.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/test/test_file_util.h"
 #include "base/threading/platform_thread.h"
 #include "base/time.h"
 #include "chrome/browser/net/url_fixer_upper.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prefs/pref_service_mock_builder.h"
 #include "chrome/common/automation_messages.h"
@@ skipping 571 matching lines @@
 
  protected:
   // Call the base class's SetUp method and initialize our own class members.
   virtual void SetUp() {
     // Set UI Test members before setting up browser.
     clear_profile_ = g_clear_profile;
 
     UITest::SetUp();
     g_browser_existing = true;
 
-    // Initialize crash_dumps_dir_path_.
-    PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dumps_dir_path_);
+    // If 'BREAKPAD_DUMP_LOCATION' environment variable is set, use it instead.
+    scoped_ptr<base::Environment> env(base::Environment::Create());
+    std::string alternate_minidump_location;
+    if (env->GetVar("BREAKPAD_DUMP_LOCATION", &alternate_minidump_location)) {
+      crash_dumps_dir_path_ = FilePath::FromUTF8Unsafe(
+          alternate_minidump_location);
+    } else {
+      PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dumps_dir_path_);

[Paweł Hajdan Jr., 2012/05/17 14:54:45]

Wait, shouldn't you modify the PathService code for DIR_CRASH_DUMPS to honor
BREAKPAD_DUMP_LOCATION?

Putting this logic on the caller side seems brittle, and may even cause code
duplication.

[chrisphan1, 2012/05/17 18:18:55]

DIR_CRASH_DUMPS gets modified in the breakpad at the moment.  Should I go ahead
and modified here instead?

[Paweł Hajdan Jr., 2012/05/21 08:30:57]

Could you explain more? I suggested modifying PathService code for
DIR_CRASH_DUMPS, instead of patching it in just _one_ place that calls
PathService (and other users of DIR_CRASH_DUMPS do not get this change).

+    }
+
     file_util::FileEnumerator enumerator(crash_dumps_dir_path_,
                                          false,  // not recursive
                                          file_util::FileEnumerator::FILES);
     for (FilePath path = enumerator.Next(); !path.value().empty();
          path = enumerator.Next()) {
       if (path.MatchesExtension(FILE_PATH_LITERAL(".dmp")))
         crash_dumps_[path.BaseName()] = true;
     }
   }
 
@@ skipping 156 matching lines @@
   if (!g_end_url.empty()) {
     NavigateToURLLogResult(
         g_end_url, log_file, NULL, g_continuous_load, false);
   }
 
   log_file.close();
 }
 
 }  // namespace