Issue 10389168: Revert 137388 - Move declarative API into events API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389168: Revert 137388 - Move declarative API into events API (Closed)

Created:
8 years, 7 months ago by battre

Modified:
8 years, 7 months ago

Reviewers:
battre

CC:
chromium-reviews, brettw-cc_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 137388 - Move declarative API into events API The motivation of this CL is to bring the declarative API and the rest of the events mechanism closer together in the API documentation. To achive this, we move the content of declarative.json and everything related to events from extension.json into the events.json API definition. The new "events" namespace is automatically provided to all extensions. BUG=126497, 112155 TEST=no Review URL: https://chromiumcodereview.appspot.com/10392008 TBR=battre@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137394

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+249 lines, -1725 lines)			Patch
M	chrome/browser/extensions/api/declarative/declarative_api.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative/declarative_api.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative/rules_registry.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_renderer.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/_permission_features.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/api.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/common/extensions/api/declarative.json	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/api/declarative_web_request.json	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/common/extensions/api/events.json	View	1 chunk	+0 lines, -247 lines	0 comments	Download
M	chrome/common/extensions/api/extension.json	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/api_index.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/common/extensions/docs/declarative.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/declarativeWebRequest.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/events.html	View	4 chunks	+4 lines, -1160 lines	0 comments	Download
M	chrome/common/extensions/docs/extension.html	View	4 chunks	+135 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/samples.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	2 chunks	+3 lines, -7 lines	0 comments	Download
A +	chrome/common/extensions/docs/static/declarative.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/static/declarativeWebRequest.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/static/events.html	View	1 chunk	+0 lines, -122 lines	0 comments	Download
M	chrome/common/extensions/extension_permission_set.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions_api_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/api_definitions_natives.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/api_definitions_natives.cc	View	2 chunks	+1 line, -28 lines	0 comments	Download
M	chrome/renderer/extensions/event_unittest.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/renderer_resources.grd	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	chrome/renderer/resources/extensions/declarative_custom_bindings.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/renderer/resources/extensions/event.js	View	5 chunks	+30 lines, -82 lines	0 comments	Download
M	chrome/renderer/resources/extensions/schema_generated_bindings.js	View	3 chunks	+8 lines, -5 lines	0 comments	Download
D	chrome/renderer/resources/extensions/utils.js	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	chrome/renderer/resources/extensions/web_request_custom_bindings.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/declarative/api/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/webrequest/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/cc_generator.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/h_generator.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages