Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/json_schema_compiler/h_generator.py

Issue 10389168: Revert 137388 - Move declarative API into events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/h_generator.py
===================================================================
--- tools/json_schema_compiler/h_generator.py (revision 137393)
+++ tools/json_schema_compiler/h_generator.py (working copy)
@@ -161,6 +161,12 @@
c = Code()
if type_.functions:
+ # Types with functions are not instantiable in C++ because they are
+ # handled in pure Javascript and hence have no properties or
+ # additionalProperties.
+ if type_.properties:
+ raise NotImplementedError('\n'.join(model.GetModelHierarchy(type_)) +
+ '\nCannot generate both functions and properties on a type')
c.Sblock('namespace %(classname)s {')
for function in type_.functions.values():
(c.Concat(self._GenerateFunction(function))
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698