Issue 10388186: RefCounted types should not have public destructors

Issue 10388186: RefCounted types should not have public destructors (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi

Modified:
8 years, 7 months ago

Reviewers:
rtenneti, joth, ramant (doing other things), sky, piman

CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jochen+watch-content_chromium.org, tburkard+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

RefCounted types should not have public destructors BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137866

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -59 lines)			Patch
M	chrome/browser/extensions/api/bluetooth/bluetooth_api.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/idltest/idltest_api.h	View	1 chunk	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/api/media_gallery/media_gallery_api.h	View	1 chunk	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/api/runtime/runtime_api.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/socket/socket_api.h	View	3 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_api.h	View	6 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/extensions/extension_record_api.h	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/managed_mode_unittest.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_store_unittest.cc	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/prerender/prerender_local_predictor.cc	View	2 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/geolocation/geolocation_provider_unittest.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/browser/tcmalloc_internals_request_job.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_hung_plugin_filter.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_hung_plugin_filter.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	net/base/tcp_listen_socket.h	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

sky: content/browser rtenneti: net/ joth: content/browser/geolocation piman: content/renderer

8 years, 7 months ago (2012-05-17 21:42:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10388186/1

8 years, 7 months ago (2012-05-18 14:16:18 UTC) #6

Change committed as 137866

Expand Messages | Collapse Messages