Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3045)

Unified Diff: chrome/browser/extensions/api/socket/socket_api.h

Issue 10388186: RefCounted types should not have public destructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_api.h ('k') | chrome/browser/extensions/api/usb/usb_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/socket/socket_api.h
diff --git a/chrome/browser/extensions/api/socket/socket_api.h b/chrome/browser/extensions/api/socket/socket_api.h
index 6815dabf47bcc02c850c0e216e9eb6f127b0015f..af22d24708a76cb30588f7bf8621e459866c2c6b 100644
--- a/chrome/browser/extensions/api/socket/socket_api.h
+++ b/chrome/browser/extensions/api/socket/socket_api.h
@@ -23,7 +23,10 @@ extern const char kSocketIdKey[];
extern const char kUdpSocketType[];
class SocketExtensionFunction : public AsyncAPIFunction {
- public:
+ protected:
+ virtual ~SocketExtensionFunction() {}
+
+ // AsyncAPIFunction:
virtual void Work() OVERRIDE;
virtual bool Respond() OVERRIDE;
};
@@ -108,7 +111,13 @@ class SocketDisconnectFunction : public SocketExtensionFunction {
};
class SocketBindFunction : public SocketExtensionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.bind")
+
protected:
+ virtual ~SocketBindFunction() {}
+
+ // AsyncAPIFunction:
virtual bool Prepare() OVERRIDE;
virtual void Work() OVERRIDE;
@@ -116,8 +125,6 @@ class SocketBindFunction : public SocketExtensionFunction {
int socket_id_;
std::string address_;
int port_;
-
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.bind")
};
class SocketReadFunction : public SocketExtensionFunction {
« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_api.h ('k') | chrome/browser/extensions/api/usb/usb_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698