RefCounted types should not have public destructors

chrome/browser/password_manager/password_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/time.h"
@@ skipping 38 matching lines @@
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
     BrowserThread::PostTask(
         BrowserThread::DB,
         FROM_HERE,
         base::Bind(&DBThreadObserverHelper::AddObserverTask,
                    this,
                    make_scoped_refptr(password_store)));
     done_event_.Wait();
   }
 
-  virtual ~DBThreadObserverHelper() {
-    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
-    registrar_.RemoveAll();
-  }
-
   content::NotificationObserverMock& observer() {
     return observer_;
   }
 
  protected:
-  friend class base::RefCountedThreadSafe<DBThreadObserverHelper>;
+  virtual ~DBThreadObserverHelper() {
+    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
+    registrar_.RemoveAll();
+  }
 
   void AddObserverTask(PasswordStore* password_store) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
     registrar_.Add(&observer_,
                    chrome::NOTIFICATION_LOGINS_CHANGED,
                    content::Source<PasswordStore>(password_store));
     done_event_.Signal();
   }
 
   WaitableEvent done_event_;
   content::NotificationRegistrar registrar_;
   content::NotificationObserverMock observer_;
+
+ private:
+  friend struct BrowserThread::DeleteOnThread<BrowserThread::DB>;
+  friend class base::DeleteHelper<DBThreadObserverHelper>;
 };
 
 }  // anonymous namespace
 
 class PasswordStoreTest : public testing::Test {
  protected:
   PasswordStoreTest()
       : ui_thread_(BrowserThread::UI, &message_loop_),
         db_thread_(BrowserThread::DB) {
   }
@@ skipping 164 matching lines @@
       .WillOnce(WithArg<1>(STLDeleteElements0())).RetiresOnSaturation();
 
   store->GetLogins(www_google, &consumer);
   store->GetLogins(accounts_google, &consumer);
   store->GetLogins(bar_example, &consumer);
 
   MessageLoop::current()->Run();
 
   STLDeleteElements(&all_forms);
 }