Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 10388036: Adds the option of aligning the launcher to the left or right. There (Closed)

Created:
8 years, 7 months ago by sky
Modified:
8 years, 7 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Adds the option of aligning the launcher to the left or right. There is a ton of rough edges after this patch, but I don't want this patch to get any bigger. BUG=121962 TEST=covered by tests. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136312

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -188 lines) Patch
M ash/ash.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +12 lines, -0 lines 0 comments Download
M ash/launcher/launcher.h View 3 chunks +13 lines, -3 lines 0 comments Download
M ash/launcher/launcher.cc View 7 chunks +20 lines, -23 lines 0 comments Download
A ash/launcher/launcher_alignment_menu.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
A ash/launcher/launcher_alignment_menu.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M ash/launcher/launcher_button_host.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/launcher/launcher_context_menu.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ash/launcher/launcher_context_menu.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M ash/launcher/launcher_types.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ash/launcher/launcher_view.h View 6 chunks +18 lines, -3 lines 0 comments Download
M ash/launcher/launcher_view.cc View 10 chunks +92 lines, -45 lines 0 comments Download
M ash/launcher/launcher_view_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/shell.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/wm/shelf_auto_hide_behavior.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/wm/shelf_layout_manager.h View 1 6 chunks +27 lines, -12 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 9 chunks +145 lines, -46 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 10 chunks +74 lines, -20 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_context_menu.h View 1 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/monitor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/monitor.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/view_model_utils.h View 1 chunk +9 lines, -2 lines 0 comments Download
M ui/views/view_model_utils.cc View 3 chunks +31 lines, -7 lines 0 comments Download
M ui/views/view_model_utils_unittest.cc View 1 chunk +40 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 7 months ago (2012-05-08 22:21:10 UTC) #1
Ben Goodger (Google)
8 years, 7 months ago (2012-05-08 22:24:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698