chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc - Issue 10388036: Adds the option of aligning the launcher to the left or right. There

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

Issue 10388036: Adds the option of aligning the launcher to the left or right. There (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

diff --git a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

index 9558ccd13bb98d8dc946d436b17d247567f3ec6c..83b86153a151cbae9cb7ed0d66b64354f61d3f6d 100644

--- a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

+++ b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

@@ -166,8 +166,8 @@ IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, ManyLauncherIcons) {

EXPECT_TRUE(WaitForFaviconDownlads(3));

EXPECT_FALSE(favicon_loader->GetFavicon().empty());

// When multiple favicons are present, the correctly sized icon should be

- // chosen. The icons are sized assuming ash::kLauncherPreferredHeight < 128.

- EXPECT_GT(128, ash::kLauncherPreferredHeight);

+ // chosen. The icons are sized assuming ash::kLauncherPreferredSize < 128.

+ EXPECT_GT(128, ash::kLauncherPreferredSize);

EXPECT_EQ(48, favicon_loader->GetFavicon().height());

}

« no previous file with comments | « chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »