Browser Plugin: PpapiCommandBufferProxy should see a lost context if the embedder has deleted the P…

ppapi/proxy/ppb_graphics_3d_proxy.cc

Index: ppapi/proxy/ppb_graphics_3d_proxy.cc
diff --git a/ppapi/proxy/ppb_graphics_3d_proxy.cc b/ppapi/proxy/ppb_graphics_3d_proxy.cc
index 75f7d83a920b8f36c5e01b90c0f47b9195c3a4ab..aa1d299d1ddd5fa7d54a9b9674c95d9322e9956c 100644
--- a/ppapi/proxy/ppb_graphics_3d_proxy.cc
+++ b/ppapi/proxy/ppb_graphics_3d_proxy.cc
@@ -248,8 +248,10 @@ void PPB_Graphics3D_Proxy::OnMsgSetGetBuffer(
 void PPB_Graphics3D_Proxy::OnMsgGetState(const HostResource& context,
                                          gpu::CommandBuffer::State* state) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
-  if (enter.failed())
+  if (enter.failed()) {
+    state->error = gpu::error::kLostContext;

[piman, 2012/05/18 02:42:46]

Mmh, this is a little bogus, because we're not filling the structure completely.
It would be better to return a success bool, so that we can keep the existing
state, but change to kLostContext on the plugin side and increase the generation
(that will probably be needed for a pepper plugin inside of a guest).
That will also remove the need for the hack in
PpapiCommandBufferProxy::UpdateState

[Fady Samuel, 2012/05/18 19:27:48]

Done.

     return;
+  }
   PP_Graphics3DTrustedState pp_state = enter.object()->GetState();
   *state = GPUStateFromPPState(pp_state);
 }
@@ -259,8 +261,10 @@ void PPB_Graphics3D_Proxy::OnMsgFlush(const HostResource& context,
                                       int32 last_known_get,
                                       gpu::CommandBuffer::State* state) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
-  if (enter.failed())
+  if (enter.failed()) {
+    state->error = gpu::error::kLostContext;
     return;
+  }
   PP_Graphics3DTrustedState pp_state = enter.object()->FlushSyncFast(
       put_offset, last_known_get);
   *state = GPUStateFromPPState(pp_state);