Browser Plugin: PpapiCommandBufferProxy should see a lost context if the embedder has deleted the P…

ppapi/proxy/ppapi_command_buffer_proxy.cc

Index: ppapi/proxy/ppapi_command_buffer_proxy.cc
diff --git a/ppapi/proxy/ppapi_command_buffer_proxy.cc b/ppapi/proxy/ppapi_command_buffer_proxy.cc
index 5e0f45486aab667646784b8aa7fc6a80696da2fd..5cdcef6642adf10c96f3ae77b0fd1457f779a195 100644
--- a/ppapi/proxy/ppapi_command_buffer_proxy.cc
+++ b/ppapi/proxy/ppapi_command_buffer_proxy.cc
@@ -262,7 +262,8 @@ void PpapiCommandBufferProxy::UpdateState(
     const gpu::CommandBuffer::State& state) {
   // Handle wraparound. It works as long as we don't have more than 2B state
   // updates in flight across which reordering occurs.
-  if (state.generation - last_state_.generation < 0x80000000U)
+  if (state.error != gpu::error::kNoError ||

[piman, 2012/05/18 02:42:46]

See comments in the other files, I'd rather the
PpapiHostMsg_PPBGraphics3D_GetState/new PpapiHostMsg_PPBGraphics3D_Flush return
failure so that we can keep the generation accounting and not clobber existing
state with uninitialized values.

[Fady Samuel, 2012/05/18 19:27:48]

Done.

+      state.generation - last_state_.generation < 0x80000000U)
     last_state_ = state;
 }