Browser Plugin: PpapiCommandBufferProxy should see a lost context if the embedder has deleted the P…

ppapi/proxy/ppb_graphics_3d_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_graphics_3d_proxy.h"
 
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/proxy/enter_proxy.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
@@ skipping 230 matching lines @@
     const HostResource& context,
     int32 transfer_buffer_id) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
   if (enter.succeeded())
     enter.object()->SetGetBuffer(transfer_buffer_id);
 }
 
 void PPB_Graphics3D_Proxy::OnMsgGetState(const HostResource& context,
                                          gpu::CommandBuffer::State* state) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
-  if (enter.failed())
+  if (enter.failed()) {
+    state->error = gpu::error::kLostContext;

[piman, 2012/05/18 02:42:46]

Mmh, this is a little bogus, because we're not filling the structure completely.
It would be better to return a success bool, so that we can keep the existing
state, but change to kLostContext on the plugin side and increase the generation
(that will probably be needed for a pepper plugin inside of a guest).
That will also remove the need for the hack in
PpapiCommandBufferProxy::UpdateState

[Fady Samuel, 2012/05/18 19:27:48]

Done.

     return;
+  }
   PP_Graphics3DTrustedState pp_state = enter.object()->GetState();
   *state = GPUStateFromPPState(pp_state);
 }
 
 void PPB_Graphics3D_Proxy::OnMsgFlush(const HostResource& context,
                                       int32 put_offset,
                                       int32 last_known_get,
                                       gpu::CommandBuffer::State* state) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
-  if (enter.failed())
+  if (enter.failed()) {
+    state->error = gpu::error::kLostContext;
     return;
+  }
   PP_Graphics3DTrustedState pp_state = enter.object()->FlushSyncFast(
       put_offset, last_known_get);
   *state = GPUStateFromPPState(pp_state);
 }
 
 void PPB_Graphics3D_Proxy::OnMsgAsyncFlush(const HostResource& context,
                                            int32 put_offset) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
   if (enter.succeeded())
     enter.object()->Flush(put_offset);
@@ skipping 54 matching lines @@
 void PPB_Graphics3D_Proxy::SendSwapBuffersACKToPlugin(
     int32_t result,
     const HostResource& context) {
   dispatcher()->Send(new PpapiMsg_PPBGraphics3D_SwapBuffersACK(
       API_ID_PPB_GRAPHICS_3D, context, result));
 }
 
 }  // namespace proxy
 }  // namespace ppapi