Browser Plugin: PpapiCommandBufferProxy should see a lost context if the embedder has deleted the P…

ppapi/proxy/ppapi_command_buffer_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppapi_command_buffer_proxy.h"
 
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/proxy_channel.h"
 #include "ppapi/shared_impl/api_id.h"
 #include "ppapi/shared_impl/host_resource.h"
@@ skipping 244 matching lines @@
     return true;
 
   last_state_.error = gpu::error::kLostContext;
   return false;
 }
 
 void PpapiCommandBufferProxy::UpdateState(
     const gpu::CommandBuffer::State& state) {
   // Handle wraparound. It works as long as we don't have more than 2B state
   // updates in flight across which reordering occurs.
-  if (state.generation - last_state_.generation < 0x80000000U)
+  if (state.error != gpu::error::kNoError ||

[piman, 2012/05/18 02:42:46]

See comments in the other files, I'd rather the
PpapiHostMsg_PPBGraphics3D_GetState/new PpapiHostMsg_PPBGraphics3D_Flush return
failure so that we can keep the generation accounting and not clobber existing
state with uninitialized values.

[Fady Samuel, 2012/05/18 19:27:48]

Done.

+      state.generation - last_state_.generation < 0x80000000U)
     last_state_ = state;
 }
 
 }  // namespace proxy
 }  // namespace ppapi