webkit/plugins/ppapi/plugin_delegate.h - Issue 10386145: Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/plugin_delegate.h

Issue 10386145: Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/proxy/ppb_graphics_3d_proxy.cc ('K') | « ppapi/proxy/ppb_graphics_3d_proxy.cc ('k') | webkit/plugins/ppapi/ppb_graphics_3d_impl.cc » ('j') | webkit/plugins/ppapi/ppb_graphics_3d_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/plugins/ppapi/plugin_delegate.h

diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h

index 304cb0905246032531a9cd8c19e479b5a87e12eb..0cfde934feb323651102af38c9ca4d22d6a13b3a 100644

--- a/webkit/plugins/ppapi/plugin_delegate.h

+++ b/webkit/plugins/ppapi/plugin_delegate.h

@@ -31,6 +31,7 @@

#include "webkit/plugins/ppapi/dir_contents.h"

#include "webkit/quota/quota_types.h"

+class CommandBufferProxy;

class GURL;

class SkBitmap;

class TransportDIB;

@@ -170,7 +171,8 @@ class PluginDelegate {

virtual ~PlatformContext3D() {}

// Initialize the context.

- virtual bool Init(const int32* attrib_list) = 0;

+ virtual bool Init(const int32* attrib_list,

+ CommandBufferProxy* share_buffer) = 0;

piman 2012/05/15 20:59:17 CommandBufferProxy here is a layering violation. I

// If the plugin instance is backed by an OpenGL, return its ID in the

// compositors namespace. Otherwise return 0. Returns 0 by default.