Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

ppapi/proxy/ppb_graphics_3d_proxy.cc

Index: ppapi/proxy/ppb_graphics_3d_proxy.cc
diff --git a/ppapi/proxy/ppb_graphics_3d_proxy.cc b/ppapi/proxy/ppb_graphics_3d_proxy.cc
index 75f7d83a920b8f36c5e01b90c0f47b9195c3a4ab..4ccd410332593992f7060c6b9844a25d216975ad 100644
--- a/ppapi/proxy/ppb_graphics_3d_proxy.cc
+++ b/ppapi/proxy/ppb_graphics_3d_proxy.cc
@@ -170,7 +170,11 @@ PP_Resource PPB_Graphics3D_Proxy::CreateProxyResource(
 
   HostResource result;
   dispatcher->Send(new PpapiHostMsg_PPBGraphics3D_Create(
-      API_ID_PPB_GRAPHICS_3D, instance, attribs, &result));
+      API_ID_PPB_GRAPHICS_3D,
+      instance,
+      ppapi::HostResource(),

[piman, 2012/05/15 20:59:17]

I don't understand, don't you want to pass the share_context resource here?

[(scshunt), 2012/05/16 16:39:43]

I haven't touched this method. Possibly yes; this is actually just a hunk from
fsamuel's patch that I had to copy over since the interface to this message
changed.

[Fady Samuel, 2012/05/16 16:43:50]

Yup, this was some stuff I changed when I started working on this plumbing.
There's no reason to do this really, just create a HostResource from PP_Instance
and PP_Resource in CreateProxyResource.

[piman, 2012/05/16 17:12:00]

Note: it's not trivially creating a HostResource(instance, share_context), the
resource IDs are different on both sides. What you want to do is lookup the
resource object and get its host_resource().
If you follow my advice for the ppb_graphics_3d_impl and move the lookup (the
EnterResource) into the thunk layer, then both sides can share that lookup code,
and you can just pass through the resource object.

+      attribs,
+      &result));
   if (result.is_null())
     return 0;
 
@@ -214,6 +218,7 @@ bool PPB_Graphics3D_Proxy::OnMessageReceived(const IPC::Message& msg) {
 }
 
 void PPB_Graphics3D_Proxy::OnMsgCreate(PP_Instance instance,
+                                       HostResource shared_context,
                                        const std::vector<int32_t>& attribs,
                                        HostResource* result) {
   if (attribs.empty() || attribs.back() != PP_GRAPHICS3DATTRIB_NONE)
@@ -221,9 +226,11 @@ void PPB_Graphics3D_Proxy::OnMsgCreate(PP_Instance instance,
 
   thunk::EnterResourceCreation enter(instance);
   if (enter.succeeded()) {
+    PP_Resource context = shared_context.host_resource();
     result->SetHostResource(
-        instance,
-        enter.functions()->CreateGraphics3DRaw(instance, 0, &attribs.front()));
+      instance,
+      enter.functions()->CreateGraphics3DRaw(instance, context,
+                                             &attribs.front()));
   }
 }