Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

webkit/plugins/ppapi/plugin_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_
 #define WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 13 matching lines @@
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_resource.h"
 #include "ppapi/c/pp_stdint.h"
 #include "ui/gfx/size.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/glue/clipboard_client.h"
 #include "webkit/plugins/ppapi/dir_contents.h"
 #include "webkit/quota/quota_types.h"
 
+class CommandBufferProxy;
 class GURL;
 class SkBitmap;
 class TransportDIB;
 struct PP_HostResolver_Private_Hint;
 struct PP_NetAddress_Private;
 
 namespace base {
 class MessageLoopProxy;
 class Time;
 }
@@ skipping 119 matching lines @@
     virtual intptr_t GetSharedMemoryHandle(uint32* byte_count) const = 0;
 
     virtual TransportDIB* GetTransportDIB() const = 0;
   };
 
   class PlatformContext3D {
    public:
     virtual ~PlatformContext3D() {}
 
     // Initialize the context.
-    virtual bool Init(const int32* attrib_list) = 0;
+    virtual bool Init(const int32* attrib_list,
+                      CommandBufferProxy* share_buffer) = 0;

[piman, 2012/05/15 20:59:17]

CommandBufferProxy here is a layering violation. It'd be better to pass the
PlatformContext3D to share with here, and grab the CommandBufferProxy inside of
the implementation

 
     // If the plugin instance is backed by an OpenGL, return its ID in the
     // compositors namespace. Otherwise return 0. Returns 0 by default.
     virtual unsigned GetBackingTextureId() = 0;
 
     // Returns true if the backing texture is always opaque.
     virtual bool IsOpaque() = 0;
 
     // This call will return the address of the command buffer for this context
     // that is constructed in Initialize() and is valid until this context is
@@ skipping 443 matching lines @@
   virtual webkit_glue::ClipboardClient* CreateClipboardClient() const = 0;
 
   // Returns a Device ID
   virtual std::string GetDeviceID() = 0;
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_