Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

ppapi/proxy/ppb_graphics_3d_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_graphics_3d_proxy.h"
 
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/proxy/enter_proxy.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
@@ skipping 152 matching lines @@
          attr[0] != PP_GRAPHICS3DATTRIB_NONE;
          attr += 2) {
       attribs.push_back(attr[0]);
       attribs.push_back(attr[1]);
     }
   }
   attribs.push_back(PP_GRAPHICS3DATTRIB_NONE);
 
   HostResource result;
   dispatcher->Send(new PpapiHostMsg_PPBGraphics3D_Create(
-      API_ID_PPB_GRAPHICS_3D, instance, attribs, &result));
+      API_ID_PPB_GRAPHICS_3D,
+      instance,
+      ppapi::HostResource(),

[piman, 2012/05/15 20:59:17]

I don't understand, don't you want to pass the share_context resource here?

[(scshunt), 2012/05/16 16:39:43]

I haven't touched this method. Possibly yes; this is actually just a hunk from
fsamuel's patch that I had to copy over since the interface to this message
changed.

[Fady Samuel, 2012/05/16 16:43:50]

Yup, this was some stuff I changed when I started working on this plumbing.
There's no reason to do this really, just create a HostResource from PP_Instance
and PP_Resource in CreateProxyResource.

[piman, 2012/05/16 17:12:00]

Note: it's not trivially creating a HostResource(instance, share_context), the
resource IDs are different on both sides. What you want to do is lookup the
resource object and get its host_resource().
If you follow my advice for the ppb_graphics_3d_impl and move the lookup (the
EnterResource) into the thunk layer, then both sides can share that lookup code,
and you can just pass through the resource object.

+      attribs,
+      &result));
   if (result.is_null())
     return 0;
 
   scoped_refptr<Graphics3D> graphics_3d(new Graphics3D(result));
   if (!graphics_3d->Init())
     return 0;
   return graphics_3d->GetReference();
 }
 
 bool PPB_Graphics3D_Proxy::OnMessageReceived(const IPC::Message& msg) {
@@ skipping 23 matching lines @@
     IPC_MESSAGE_HANDLER(PpapiMsg_PPBGraphics3D_SwapBuffersACK,
                         OnMsgSwapBuffersACK)
     IPC_MESSAGE_UNHANDLED(handled = false)
 
   IPC_END_MESSAGE_MAP()
   // FIXME(brettw) handle bad messages!
   return handled;
 }
 
 void PPB_Graphics3D_Proxy::OnMsgCreate(PP_Instance instance,
+                                       HostResource shared_context,
                                        const std::vector<int32_t>& attribs,
                                        HostResource* result) {
   if (attribs.empty() || attribs.back() != PP_GRAPHICS3DATTRIB_NONE)
     return;  // Bad message.
 
   thunk::EnterResourceCreation enter(instance);
   if (enter.succeeded()) {
+    PP_Resource context = shared_context.host_resource();
     result->SetHostResource(
-        instance,
-        enter.functions()->CreateGraphics3DRaw(instance, 0, &attribs.front()));
+      instance,
+      enter.functions()->CreateGraphics3DRaw(instance, context,
+                                             &attribs.front()));
   }
 }
 
 void PPB_Graphics3D_Proxy::OnMsgInitCommandBuffer(
     const HostResource& context) {
   EnterHostFromHostResource<PPB_Graphics3D_API> enter(context);
   if (enter.failed())
     return;
 
   if (!enter.object()->InitCommandBuffer())
@@ skipping 91 matching lines @@
 void PPB_Graphics3D_Proxy::SendSwapBuffersACKToPlugin(
     int32_t result,
     const HostResource& context) {
   dispatcher()->Send(new PpapiMsg_PPBGraphics3D_SwapBuffersACK(
       API_ID_PPB_GRAPHICS_3D, context, result));
 }
 
 }  // namespace proxy
 }  // namespace ppapi