Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 10386048: Decouple DevTools from socket implementation. (Closed)

Created:
8 years, 7 months ago by Philippe
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, mnaganov (inactive)
Visibility:
Public.

Description

Decouple DevTools from socket implementation. This is part of Chrome for Android upstreaming. This will let us use a UnixDomainSocket for DevTools on Android. Note that this CL depends on CL 10161005 (which should land soon). TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138497

Patch Set 1 #

Patch Set 2 : Update #

Total comments: 22

Patch Set 3 : Address Pavel's comments #

Total comments: 2

Patch Set 4 : Address Pavel's comments #

Total comments: 8

Patch Set 5 : Address Matt's comments #

Total comments: 2

Patch Set 6 : Address Matt's last comment + sync #

Patch Set 7 : Add missing NET_EXPORT #

Patch Set 8 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -36 lines) Patch
M chrome/browser/debugger/remote_debugging_server.cc View 1 2 3 4 5 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 1 2 3 4 3 chunks +6 lines, -10 lines 0 comments Download
M content/public/browser/devtools_http_handler.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_devtools_delegate.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/stream_listen_socket.h View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M net/base/tcp_listen_socket.h View 1 2 3 4 5 6 7 2 chunks +19 lines, -0 lines 0 comments Download
M net/base/tcp_listen_socket.cc View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M net/server/http_connection.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M net/server/http_server.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M net/server/http_server.cc View 1 2 3 4 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
Philippe
Update
8 years, 7 months ago (2012-05-11 08:03:27 UTC) #1
Philippe
8 years, 7 months ago (2012-05-14 09:50:54 UTC) #2
pfeldman
http://codereview.chromium.org/10386048/diff/20/chrome/browser/debugger/remote_debugging_server.cc File chrome/browser/debugger/remote_debugging_server.cc (right): http://codereview.chromium.org/10386048/diff/20/chrome/browser/debugger/remote_debugging_server.cc#newcode26 chrome/browser/debugger/remote_debugging_server.cc:26: new net::TCPListenSocketFactory factory(ip, port), Remove " factory" http://codereview.chromium.org/10386048/diff/20/content/browser/debugger/devtools_http_handler_impl.cc File ...
8 years, 7 months ago (2012-05-14 11:12:00 UTC) #3
Philippe
http://codereview.chromium.org/10386048/diff/20/chrome/browser/debugger/remote_debugging_server.cc File chrome/browser/debugger/remote_debugging_server.cc (right): http://codereview.chromium.org/10386048/diff/20/chrome/browser/debugger/remote_debugging_server.cc#newcode26 chrome/browser/debugger/remote_debugging_server.cc:26: new net::TCPListenSocketFactory factory(ip, port), On 2012/05/14 11:12:00, pfeldman wrote: ...
8 years, 7 months ago (2012-05-14 12:36:52 UTC) #4
pfeldman
lgtm > > Why scoped_refptr? > What do you think? > I got used to ...
8 years, 7 months ago (2012-05-14 13:38:41 UTC) #5
Philippe
Thanks for the quick review Pavel! Let's also see what Matt thinks. I also need ...
8 years, 7 months ago (2012-05-14 13:52:00 UTC) #6
mmenke
http://codereview.chromium.org/10386048/diff/20/content/browser/debugger/devtools_http_handler_impl.cc File content/browser/debugger/devtools_http_handler_impl.cc (right): http://codereview.chromium.org/10386048/diff/20/content/browser/debugger/devtools_http_handler_impl.cc#newcode136 content/browser/debugger/devtools_http_handler_impl.cc:136: new DevToolsHttpHandlerImpl(frontend_url, On 2012/05/14 12:36:52, Philippe wrote: > On ...
8 years, 7 months ago (2012-05-14 20:45:19 UTC) #7
Philippe
http://codereview.chromium.org/10386048/diff/20/content/browser/debugger/devtools_http_handler_impl.cc File content/browser/debugger/devtools_http_handler_impl.cc (right): http://codereview.chromium.org/10386048/diff/20/content/browser/debugger/devtools_http_handler_impl.cc#newcode136 content/browser/debugger/devtools_http_handler_impl.cc:136: new DevToolsHttpHandlerImpl(frontend_url, On 2012/05/14 20:45:19, Matt Menke wrote: > ...
8 years, 7 months ago (2012-05-15 14:39:08 UTC) #8
mmenke
LGTM, modulo one rather important comment, though suppose it would result in a build error, ...
8 years, 7 months ago (2012-05-15 17:40:40 UTC) #9
Philippe
Thanks for the review guys! I'm adding avi@ for content/. https://chromiumcodereview.appspot.com/10386048/diff/14013/chrome/browser/debugger/remote_debugging_server.cc File chrome/browser/debugger/remote_debugging_server.cc (right): https://chromiumcodereview.appspot.com/10386048/diff/14013/chrome/browser/debugger/remote_debugging_server.cc#newcode26 ...
8 years, 7 months ago (2012-05-16 16:56:24 UTC) #10
Avi (use Gerrit)
content lgtm
8 years, 7 months ago (2012-05-16 17:00:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/12041
8 years, 7 months ago (2012-05-18 09:00:18 UTC) #12
commit-bot: I haz the power
Try job failure for 10386048-12041 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-18 09:17:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/22002
8 years, 7 months ago (2012-05-21 14:04:12 UTC) #14
commit-bot: I haz the power
Try job failure for 10386048-22002 (retry) on win for step "update". It's a second try, ...
8 years, 7 months ago (2012-05-21 14:58:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/22002
8 years, 7 months ago (2012-05-21 16:35:25 UTC) #16
commit-bot: I haz the power
Try job failure for 10386048-22002 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-21 17:51:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/22002
8 years, 7 months ago (2012-05-22 09:22:16 UTC) #18
commit-bot: I haz the power
Try job failure for 10386048-22002 (retry) (previous was lost) on win_rel for steps "base_unittests, browser_tests, ...
8 years, 7 months ago (2012-05-22 11:51:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/22002
8 years, 7 months ago (2012-05-22 11:59:12 UTC) #20
commit-bot: I haz the power
Failed to apply the patch.
8 years, 7 months ago (2012-05-22 12:07:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/22002
8 years, 7 months ago (2012-05-22 15:25:18 UTC) #22
commit-bot: I haz the power
Try job failure for 10386048-22002 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 15:48:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/22002
8 years, 7 months ago (2012-05-22 16:14:33 UTC) #24
commit-bot: I haz the power
Try job failure for 10386048-22002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 17:50:13 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10386048/22002
8 years, 7 months ago (2012-05-23 11:14:48 UTC) #26
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 17:05:33 UTC) #27
Change committed as 138497

Powered by Google App Engine
This is Rietveld 408576698